Commit graph

2486 commits

Author SHA1 Message Date
Jordan Eldredge
8933b16f16 Lower screenshot threshold 2019-08-27 13:12:31 -07:00
Jordan Eldredge
6383334f09
Try out Actions (#892)
* Update nodejs.yml

* Try using Yarn

* push is more generic than pull_request

We don't need both
2019-08-27 13:05:31 -07:00
dependabot[bot]
5deedf6846 Bump eslint-utils from 1.4.0 to 1.4.2 (#891)
Bumps [eslint-utils](https://github.com/mysticatea/eslint-utils) from 1.4.0 to 1.4.2.
- [Release notes](https://github.com/mysticatea/eslint-utils/releases)
- [Commits](https://github.com/mysticatea/eslint-utils/compare/v1.4.0...v1.4.2)

Signed-off-by: dependabot[bot] <support@github.com>
2019-08-26 14:31:12 -07:00
jberg
70b9e98aea Fix emitter export (#890) 2019-08-26 11:56:48 -07:00
jberg
34a68ae64f Remove script loading from initialize (#889) 2019-08-26 09:13:35 -07:00
Jordan Eldredge
cee3c14bd5 Improve types 2019-08-26 09:11:19 -07:00
Jordan Eldredge
3f7590817f Decompose findParentNodeOfType 2019-08-26 09:11:19 -07:00
Jordan Eldredge
10a722f613 Letters are cheap 2019-08-26 09:11:19 -07:00
jberg
3a8f8055e8
Set opacity and ghost at GuiObject (#885)
* Set opacity and ghost at GuiObject

* add parseInt radix param

* move style calculations into GuiObjectEvents

* fixes after rebasing

* add alpha range in comment

* simplify alpha condition
2019-08-25 15:24:42 -07:00
Jordan Eldredge
8dbf348dba Add some generic methods for dealing with selectors (#888) 2019-08-24 23:49:21 -07:00
Jordan Eldredge
98bcf9f682 Stub Out Missing Methods (#887)
* Add fixable rule to report missing Maki methods

* Stub out missing methods

These were auto-generated with the ESLint rule

* Don't lint on too many params, when the params are defined by Maki

* Improve objects tests now that all maki methods are stubbed out

Now we can assume all methods exist and we can also start a list of unimplemented methods
2019-08-24 23:04:50 -07:00
Jordan Eldredge
83d9443328 Fix lints 2019-08-24 22:30:48 -07:00
Jordan Eldredge
948c96dc64 Allow private methods in objects test 2019-08-24 22:17:28 -07:00
Jordan Eldredge
b52879475f Don't complain about private methods 2019-08-24 21:46:16 -07:00
Jordan Eldredge
b67ebc2ca2
[WIP] Give Maki objects access to Redux state (#882)
* Share uids between maki objects and state tree

* Start to add xml tree
2019-08-24 21:10:00 -07:00
Jordan Eldredge
3af4d703d6
Avoid messagebox logs in our tests (#884)
This was a fun one
2019-08-23 08:19:32 -07:00
Jordan Eldredge
e7637b3b3c Test method arity in standard library 2019-08-23 08:18:24 -07:00
Jordan Eldredge
dac6585675
Add modern integration tests (#881)
* add 2 test skins

* Add simple integration tests

* Simplify test skins
2019-08-21 21:42:07 -07:00
Jordan Eldredge
66e5091811 Persist skin URL to query param 2019-08-21 21:41:41 -07:00
jberg
d17333d428 Add missing config classes (#874)
* Add missing config classes

* fix test
2019-08-21 21:04:13 -07:00
Jordan Eldredge
1a7be6bce7 Add flag to state indicating when skin is loaded 2019-08-21 20:15:11 -07:00
Jordan Eldredge
e3b5031f29 Extract browser-only functions into Utils
This will make it easier to mock out these methods in tests to use Node apporaches to these problems
2019-08-21 20:06:11 -07:00
jberg
bae6a56458 Fix filename slashes (#880)
* Fix windows filename slashes

* add comment

* readXml will already convert the slashes
2019-08-21 16:30:21 -07:00
jberg
0fc4aacbbc Fix script group finding (#877) 2019-08-21 14:35:59 -07:00
Jordan Eldredge
84651f4567 Fix typing for Desktop 2019-08-20 09:19:19 -07:00
Jordan Eldredge
983b574da2 Actually use useDispatch 2019-08-20 09:10:12 -07:00
Jordan Eldredge
0b3d28767f Don't allow global access to all of window
We had a bug where `stop()` was undefined but it fell back to the function on window which was inplicitly in the global scope.

This should reduce that kind of thing.
2019-08-20 07:43:23 -07:00
Jordan Eldredge
6a53539776 Make Desktop a functional component with hooks 2019-08-20 07:43:23 -07:00
Jordan Eldredge
2a5798012f Make AlbumsTable a functional component 2019-08-20 07:43:23 -07:00
Jordan Eldredge
5407426325 Fix the stop button
Aparently window.stop() is a thing, and ESLint/TypeScript let me do this. Sigh.

A potential fix: https://github.com/facebook/create-react-app/pull/1840
2019-08-20 07:43:23 -07:00
Jordan Eldredge
7a1191c1e5 Use react-redux hooks for MainWindow/index
This is the last main window component still using the HOC!
2019-08-20 07:43:23 -07:00
Jordan Eldredge
54eba236ef Remove unused types 2019-08-20 07:43:23 -07:00
Jordan Eldredge
7212b9e895 Use react-redux for Position and Repeat 2019-08-20 07:43:23 -07:00
Jordan Eldredge
cc0e1aa5ee Use react-redux hooks in Shade 2019-08-20 07:43:23 -07:00
Jordan Eldredge
576689642a Use react-redux hooks in Shuffle 2019-08-20 07:43:23 -07:00
Jordan Eldredge
2e95a04ec9 Use react-redux hooks in Time 2019-08-20 07:43:23 -07:00
Jordan Eldredge
357c139af5 Use hooks for main context window 2019-08-20 07:43:23 -07:00
Jordan Eldredge
a0c01272bd Type PlaylistTogggleButton 2019-08-20 07:43:23 -07:00
Jordan Eldredge
3cb7de0ba0 Inline style 2019-08-20 07:43:23 -07:00
Jordan Eldredge
2c7c449b1a Use react-redux hooks for Marquee 2019-08-20 07:43:23 -07:00
Jordan Eldredge
eaf9e8e27a Clean up unused type 2019-08-20 07:43:23 -07:00
Jordan Eldredge
6f54b5aeab Use react-redux hooks in a few more places 2019-08-20 07:43:23 -07:00
Jordan Eldredge
48bd60bff7 Refactor Marquee to use hooks
This actually removes a bunch of edgecases/race conditions
2019-08-20 07:43:23 -07:00
jberg
533d7f3f8f add button left/rightclick functions (#878) 2019-08-20 07:40:45 -07:00
jberg
ceb85fa4be
Add delete opcode (#869) 2019-08-19 14:43:06 -07:00
jberg
59689fa827 Add some unimplemented methods to classes (#872)
* Add some unimplemented methods to classes

* fix test
2019-08-19 10:25:27 -07:00
jberg
378c9c595b Pass store into skin loading (#875) 2019-08-19 10:22:44 -07:00
jberg
39c3a25c0a Add more nodes to initialize (#873) 2019-08-19 10:22:18 -07:00
jberg
8ab2990f20 Add some more methods to classes (#871)
* Add some more methods to classes

* fix test
2019-08-19 10:21:31 -07:00
jberg
eda8d028c2 First check object type for subclass (#870) 2019-08-19 10:20:51 -07:00