mirror of
https://github.com/transloadit/uppy.git
synced 2026-07-23 02:08:30 +00:00
79e6460a6c
fixes #6024. ### Problem - `getPlugin()` defaults to `UnknownPlugin`, so methods like `openModal` are not visible , since core is not aware of that plugin type ### Proposed change - Introduce a types-only registry in core: - `export interface PluginTypeRegistry<M extends Meta, B extends Body> {}` - Overload `getPlugin` to return a precise type when the id is a known key of the registry. - add `Dashboard` to PluginTypeRegistry through module augmentation: - `'Dashboard': Dashboard<M, B>`. - When a project imports from `@uppy/dashboard`, its module augmentation extends PluginTypeRegistry, adding the correct type into it - I've added Tests , kept them in a separate file so it's easier to review , once this approach gets approved I'll add them to `Uppy.test.ts` Once this PR gets a positive review I'll add this for other plugins , currently only added for `@uppy/dashboard` **Build with Local tarball can be checked here** https://stackblitz.com/~/github.com/qxprakash/uppy-type-test?file=type_test.ts |
||
|---|---|---|
| .. | ||
| CameraIcon.tsx | ||
| CameraScreen.tsx | ||
| DiscardButton.tsx | ||
| formatSeconds.test.ts | ||
| formatSeconds.ts | ||
| index.ts | ||
| locale.ts | ||
| PermissionsScreen.tsx | ||
| RecordButton.tsx | ||
| RecordingLength.tsx | ||
| SnapshotButton.tsx | ||
| style.scss | ||
| SubmitButton.tsx | ||
| supportsMediaRecorder.test.ts | ||
| supportsMediaRecorder.ts | ||
| VideoSourceSelect.tsx | ||
| Webcam.test.ts | ||
| Webcam.tsx | ||