Run biome check on main (#5896)

this time on main
closes #5891

also: fix a11y tabIndex (key event handler)

biome.json

@@ -47,7 +47,6 @@
       "correctness": {
         "useExhaustiveDependencies": "error",
         "useHookAtTopLevel": "error",
-        "noUnusedImports": "off",
         "noUnusedFunctionParameters": "off",
         "noUnusedVariables": {
           "level": "error",

examples/companion-custom-provider/client/MyCustomProvider.jsx

@@ -3,7 +3,6 @@
 import { getAllowedHosts, Provider, tokenStorage } from '@uppy/companion-client'
 import { UIPlugin } from '@uppy/core'
 import { ProviderViews } from '@uppy/provider-views'
-import { h } from 'preact'
 
 const defaultOptions = {}
 

examples/react-native-expo/App.js

@@ -2,7 +2,7 @@ import AsyncStorage from '@react-native-async-storage/async-storage'
 import Uppy from '@uppy/core'
 import FilePicker from '@uppy/react-native'
 import Tus from '@uppy/tus'
-import React, { useCallback, useEffect, useState } from 'react'
+import { useCallback, useEffect, useState } from 'react'
 import { Image, StyleSheet, Text, View } from 'react-native'
 import FileList from './FileList'
 import PauseResumeButton from './PauseResumeButton'

examples/react-native-expo/FileList.js

@@ -1,6 +1,5 @@
 import getFileTypeIcon from '@uppy/dashboard/lib/utils/getFileTypeIcon.js'
 import renderStringFromJSX from 'preact-render-to-string'
-import React from 'react'
 import { FlatList, Image, StyleSheet, Text, View } from 'react-native'
 
 const fileIcon = require('./assets/file-icon.png')

examples/react-native-expo/PauseResumeButton.js

@@ -1,4 +1,3 @@
-import React from 'react'
 import { StyleSheet, Text, TouchableHighlight } from 'react-native'
 
 export default function PauseResumeButton({

examples/react-native-expo/ProgressBar.js

@@ -1,4 +1,3 @@
-import React from 'react'
 import { StyleSheet, Text, View } from 'react-native'
 
 const colorGreen = '#0b8600'

examples/react-native-expo/SelectFilesButton.js

@@ -1,4 +1,3 @@
-import React from 'react'
 import { StyleSheet, Text, TouchableHighlight } from 'react-native'
 
 export default function SelectFiles({ showFilePicker }) {

examples/react/src/MediaCapture.tsx

@@ -1,5 +1,3 @@
-import React from 'react'
-
 type ButtonProps = {
   type: 'button'
   onClick: () => void

examples/react/src/ScreenCapture.tsx

@@ -1,5 +1,5 @@
 import { useScreenCapture } from '@uppy/react'
-import React, { useEffect } from 'react'
+import { useEffect } from 'react'
 import MediaCapture from './MediaCapture.tsx'
 
 export interface ScreenCaptureProps {

examples/react/src/Webcam.tsx

@@ -1,5 +1,5 @@
 import { useWebcam } from '@uppy/react'
-import React, { useEffect } from 'react'
+import { useEffect } from 'react'
 import MediaCapture from './MediaCapture.tsx'
 
 export interface WebcamProps {

examples/transloadit/server.js

@@ -36,6 +36,7 @@ function Footer() {
 }
 
 function FormFields(fields) {
+  // biome-ignore lint/nursery/noNestedComponentDefinitions: not a react component
   function Field([name, value]) {
     if (name === 'transloadit') return ''
     let isValueJSON = false
@@ -75,6 +76,7 @@ function FormFields(fields) {
 }
 
 function UploadsList(uploads) {
+  // biome-ignore lint/nursery/noNestedComponentDefinitions: not a react component
   function Upload(upload) {
     return `<li>${e(upload.name)}</li>`
   }
@@ -87,10 +89,12 @@ function UploadsList(uploads) {
 }
 
 function ResultsList(results) {
+  // biome-ignore lint/nursery/noNestedComponentDefinitions: not a react component
   function Result(result) {
     return `<li>${e(result.name)} <a href="${result.ssl_url}" target="_blank">View</a></li>`
   }
 
+  // biome-ignore lint/nursery/noNestedComponentDefinitions: not a react component
   function ResultsSection(stepName) {
     return `
     <h2>${e(stepName)}</h2>

packages/@uppy/audio/src/Audio.tsx

@@ -10,7 +10,6 @@ import { UIPlugin } from '@uppy/core'
 import getFileTypeExtension from '@uppy/utils/lib/getFileTypeExtension'
 
 import type { LocaleStrings } from '@uppy/utils/lib/Translator'
-import { h } from 'preact'
 import packageJson from '../package.json' with { type: 'json' }
 import locale from './locale.js'
 import PermissionsScreen from './PermissionsScreen.js'

packages/@uppy/audio/src/AudioSourceSelect.tsx

@@ -1,5 +1,3 @@
-import { h } from 'preact'
-
 export interface AudioSourceSelectProps {
   currentDeviceId: string | MediaStreamTrack | null | undefined
   audioSources: MediaDeviceInfo[]

packages/@uppy/audio/src/DiscardButton.tsx

@@ -1,5 +1,4 @@
 import type { I18n } from '@uppy/utils/lib/Translator'
-import { h } from 'preact'
 
 interface DiscardButtonProps {
   onDiscard: () => void

packages/@uppy/audio/src/PermissionsScreen.tsx

@@ -1,5 +1,5 @@
 import type { I18n } from '@uppy/utils/lib/Translator'
-import { h } from 'preact'
+import type { h } from 'preact'
 
 interface PermissionsScreenProps {
   icon: () => h.JSX.Element | null

packages/@uppy/audio/src/RecordButton.tsx

@@ -1,5 +1,4 @@
 import type { I18n } from '@uppy/utils/lib/Translator'
-import { h } from 'preact'
 
 interface RecordButtonProps {
   recording: boolean

packages/@uppy/audio/src/RecordingLength.tsx

@@ -1,4 +1,3 @@
-import { h } from 'preact'
 import formatSeconds from './formatSeconds.js'
 
 interface RecordingLengthProps {

packages/@uppy/audio/src/RecordingScreen.tsx

@@ -1,5 +1,4 @@
 import type { I18n } from '@uppy/utils/lib/Translator'
-import { h } from 'preact'
 import { useEffect, useRef } from 'preact/hooks'
 import AudioSourceSelect, {
   type AudioSourceSelectProps,

packages/@uppy/audio/src/SubmitButton.tsx

@@ -1,5 +1,4 @@
 import type { I18n } from '@uppy/utils/lib/Translator'
-import { h } from 'preact'
 
 interface SubmitButtonProps {
   onSubmit: () => void

packages/@uppy/components/src/Dropzone.tsx

@@ -1,5 +1,4 @@
 import { clsx } from 'clsx'
-import { h } from 'preact'
 import { useMemo } from 'preact/hooks'
 import { createDropzone } from './hooks/dropzone.js'
 import type { NonNullableUppyContext, UppyContext } from './types.js'
@@ -29,7 +28,6 @@ export default function Dropzone(props: DropzoneProps) {
       className="uppy-reset"
       data-uppy-element="dropzone"
       role="presentation"
-      tabIndex={0}
     >
       <input
         {...getInputProps()}
@@ -39,6 +37,8 @@ export default function Dropzone(props: DropzoneProps) {
       />
       <div
         {...getRootProps()}
+        // biome-ignore lint/a11y/noNoninteractiveTabindex: it is also a button. getRootProps returns keyboard event handlers
+        tabIndex={0}
         style={{
           width: width || '100%',
           height: height || '100%',

packages/@uppy/components/src/FilesGrid.tsx

@@ -1,6 +1,6 @@
 import type { Body, Meta, UppyEventMap, UppyFile } from '@uppy/core'
 import { clsx } from 'clsx'
-import { Fragment, h } from 'preact'
+import { Fragment } from 'preact'
 import { useEffect, useState } from 'preact/hooks'
 import prettyBytes from 'pretty-bytes'
 import { Thumbnail } from './index.js'

packages/@uppy/components/src/FilesList.tsx

@@ -1,6 +1,6 @@
 import type { Body, Meta, UppyEventMap, UppyFile } from '@uppy/core'
 import { clsx } from 'clsx'
-import { Fragment, h } from 'preact'
+import { Fragment } from 'preact'
 import { useEffect, useState } from 'preact/hooks'
 import prettyBytes from 'pretty-bytes'
 import { Thumbnail, type UppyContext } from './index.js'

packages/@uppy/components/src/ProviderIcon.tsx

@@ -1,4 +1,3 @@
-import { h } from 'preact'
 import type { UppyContext } from './types.js'
 
 export type ProviderIconProps = {

packages/@uppy/components/src/Thumbnail.tsx

@@ -1,5 +1,4 @@
 import type { Body, Meta, UppyFile } from '@uppy/core'
-import { h } from 'preact'
 import { useEffect, useMemo } from 'preact/hooks'
 import type { UppyContext } from './types.js'
 

packages/@uppy/components/src/UploadButton.tsx

@@ -1,5 +1,4 @@
 import { clsx } from 'clsx'
-import { h } from 'preact'
 import type { UppyContext } from './types.js'
 
 export type UploadButtonProps = {

packages/@uppy/components/src/hooks/dropzone.ts

@@ -76,6 +76,18 @@ export function createDropzone<
     input?.click()
   }
 
+  const handleKeyPress = (event: KeyboardEvent) => {
+    // taken from https://github.com/react-dropzone/react-dropzone/blob/d6911c991e077151e302b599b92269432ab0472b/src/index.js#L830C1-L836C1
+    if (
+      event.key === ' ' ||
+      event.key === 'Enter' ||
+      event.keyCode === 32 ||
+      event.keyCode === 13
+    ) {
+      handleClick()
+    }
+  }
+
   const handleFileInputChange = (event: ChangeEventType) => {
     const input = event.target as HTMLInputElement
     const files = Array.from(input.files ?? [])
@@ -103,6 +115,7 @@ export function createDropzone<
       onDragLeave: handleDragLeave,
       onDrop: handleDrop,
       onClick: handleClick,
+      onKeyPress: handleKeyPress,
     }),
     getInputProps: () => ({
       id: fileInputId,

packages/@uppy/dashboard/src/Dashboard.tsx

@@ -21,7 +21,6 @@ import type { LocaleStrings } from '@uppy/utils/lib/Translator'
 import toArray from '@uppy/utils/lib/toArray'
 import { nanoid } from 'nanoid/non-secure'
 import type { ComponentChild, VNode } from 'preact'
-import { h } from 'preact'
 import type { TargetedEvent } from 'preact/compat'
 import packageJson from '../package.json' with { type: 'json' }
 import DashboardUI from './components/Dashboard.js'

packages/@uppy/dashboard/src/components/AddFiles.tsx

@@ -1,6 +1,6 @@
 import type Translator from '@uppy/utils/lib/Translator'
 import type { I18n } from '@uppy/utils/lib/Translator'
-import { Component, type ComponentChild, Fragment, h } from 'preact'
+import { Component, type ComponentChild, Fragment } from 'preact'
 import type { TargetedEvent } from 'preact/compat'
 import type { DashboardState, TargetWithRender } from '../Dashboard.js'
 

packages/@uppy/dashboard/src/components/AddFilesPanel.tsx

@@ -1,5 +1,4 @@
 import classNames from 'classnames'
-import { h } from 'preact'
 import AddFiles from './AddFiles.js'
 
 type $TSFixMe = any

packages/@uppy/dashboard/src/components/Dashboard.tsx

@@ -11,7 +11,6 @@ import isDragDropSupported from '@uppy/utils/lib/isDragDropSupported'
 import type Translator from '@uppy/utils/lib/Translator'
 import type { I18n } from '@uppy/utils/lib/Translator'
 import classNames from 'classnames'
-import { h } from 'preact'
 import type { TargetedEvent } from 'preact/compat'
 import type { DashboardState, TargetWithRender } from '../Dashboard.js'
 import AddFiles from './AddFiles.js'

packages/@uppy/dashboard/src/components/EditorPanel.tsx

@@ -1,5 +1,4 @@
 import classNames from 'classnames'
-import { h } from 'preact'
 
 type $TSFixMe = any
 

packages/@uppy/dashboard/src/components/FileCard/index.tsx

@@ -1,6 +1,5 @@
 import classNames from 'classnames'
 import { nanoid } from 'nanoid/non-secure'
-import { h } from 'preact'
 import { useCallback, useEffect, useState } from 'preact/hooks'
 import getFileTypeIcon from '../../utils/getFileTypeIcon.js'
 import ignoreEvent from '../../utils/ignoreEvent.js'

packages/@uppy/dashboard/src/components/FileItem/Buttons/index.tsx

@@ -1,7 +1,6 @@
 import type Uppy from '@uppy/core'
 import type { Body, Meta, UppyFile } from '@uppy/core'
 import type { I18n } from '@uppy/utils/lib/Translator'
-import { h } from 'preact'
 import type { DashboardState } from '../../../Dashboard.js'
 import copyToClipboard from '../../../utils/copyToClipboard.js'
 

packages/@uppy/dashboard/src/components/FileItem/FileInfo/index.tsx

@@ -2,7 +2,6 @@ import prettierBytes from '@transloadit/prettier-bytes'
 import type { UppyFile } from '@uppy/core'
 import type { I18n } from '@uppy/utils/lib/Translator'
 import truncateString from '@uppy/utils/lib/truncateString'
-import { h } from 'preact'
 import type { DashboardState } from '../../../Dashboard.js'
 import MetaErrorMessage from '../MetaErrorMessage.js'
 

packages/@uppy/dashboard/src/components/FileItem/FilePreviewAndLink/index.tsx

@@ -1,4 +1,3 @@
-import { h } from 'preact'
 import getFileTypeIcon from '../../../utils/getFileTypeIcon.js'
 import FilePreview from '../../FilePreview.js'
 import MetaErrorMessage from '../MetaErrorMessage.js'

packages/@uppy/dashboard/src/components/FileItem/FileProgress/index.tsx

@@ -1,6 +1,6 @@
 import type { Body, Meta, State, Uppy, UppyFile } from '@uppy/core'
 import type { I18n } from '@uppy/utils/lib/Translator'
-import { type ComponentChild, h } from 'preact'
+import type { ComponentChild } from 'preact'
 
 interface Props<M extends Meta, B extends Body> {
   uppy: Uppy<M, B>

packages/@uppy/dashboard/src/components/FileItem/MetaErrorMessage.tsx

@@ -1,5 +1,3 @@
-import { h } from 'preact'
-
 type $TSFixMe = any
 
 const metaFieldIdToName = (metaFieldId: $TSFixMe, metaFields: $TSFixMe) => {

packages/@uppy/dashboard/src/components/FileList.tsx

@@ -2,7 +2,6 @@ import type { Body, Meta, State, Uppy, UppyFile } from '@uppy/core'
 import type { I18n } from '@uppy/utils/lib/Translator'
 // @ts-ignore untyped
 import VirtualList from '@uppy/utils/lib/VirtualList'
-import { h } from 'preact'
 import { useMemo } from 'preact/hooks'
 import type { DashboardState } from '../Dashboard.js'
 import FileItem from './FileItem/index.js'

packages/@uppy/dashboard/src/components/FilePreview.tsx

@@ -1,4 +1,3 @@
-import { h } from 'preact'
 import getFileTypeIcon from '../utils/getFileTypeIcon.js'
 
 type $TSFixMe = any

packages/@uppy/dashboard/src/components/PickerPanelContent.tsx

@@ -1,5 +1,4 @@
 import classNames from 'classnames'
-import { h } from 'preact'
 import { useRef } from 'preact/hooks'
 import ignoreEvent from '../utils/ignoreEvent.js'
 

packages/@uppy/dashboard/src/components/PickerPanelTopBar.tsx

@@ -1,5 +1,4 @@
 import type { UppyFile } from '@uppy/core'
-import { h } from 'preact'
 
 type $TSFixMe = any
 

packages/@uppy/dashboard/src/components/Slide.tsx

@@ -2,11 +2,10 @@ import classNames from 'classnames'
 import {
   type ComponentChildren,
   cloneElement,
-  h,
   toChildArray,
   type VNode,
 } from 'preact'
-import { useEffect, useRef, useState } from 'preact/hooks'
+import { useCallback, useEffect, useRef, useState } from 'preact/hooks'
 
 const transitionName = 'uppy-transition-slideDownUp'
 const duration = 250
@@ -29,7 +28,7 @@ function Slide({ children }: { children: ComponentChildren }) {
   const leaveTimeoutRef = useRef<ReturnType<typeof setTimeout>>()
   const animationFrameRef = useRef<ReturnType<typeof requestAnimationFrame>>()
 
-  const handleEnterTransition = () => {
+  const handleEnterTransition = useCallback(() => {
     setClassName(`${transitionName}-enter`)
 
     cancelAnimationFrame(animationFrameRef.current!)
@@ -43,9 +42,9 @@ function Slide({ children }: { children: ComponentChildren }) {
         setClassName('')
       }, duration)
     })
-  }
+  }, [])
 
-  const handleLeaveTransition = () => {
+  const handleLeaveTransition = useCallback(() => {
     setClassName(`${transitionName}-leave`)
 
     cancelAnimationFrame(animationFrameRef.current!)
@@ -60,7 +59,7 @@ function Slide({ children }: { children: ComponentChildren }) {
         setClassName('')
       }, duration)
     })
-  }
+  }, [])
 
   useEffect(() => {
     const child = toChildArray(children)[0] as VNode
@@ -73,7 +72,7 @@ function Slide({ children }: { children: ComponentChildren }) {
     }
 
     setCachedChildren(child)
-  }, [children, cachedChildren]) // Dependency array to trigger effect on children change
+  }, [children, cachedChildren, handleEnterTransition, handleLeaveTransition]) // Dependency array to trigger effect on children change
 
   useEffect(() => {
     return () => {

packages/@uppy/dashboard/src/utils/getFileTypeIcon.tsx

@@ -1,5 +1,3 @@
-import { h } from 'preact'
-
 type $TSFixMe = any
 
 function iconImage() {

packages/@uppy/drag-drop/src/DragDrop.tsx

@@ -10,7 +10,7 @@ import getDroppedFiles from '@uppy/utils/lib/getDroppedFiles'
 import isDragDropSupported from '@uppy/utils/lib/isDragDropSupported'
 import type { LocaleStrings } from '@uppy/utils/lib/Translator'
 import toArray from '@uppy/utils/lib/toArray'
-import { type ComponentChild, h } from 'preact'
+import type { ComponentChild } from 'preact'
 import type { TargetedEvent } from 'preact/compat'
 import packageJson from '../package.json' with { type: 'json' }
 import locale from './locale.js'

packages/@uppy/google-drive-picker/src/GoogleDrivePicker.tsx

@@ -9,7 +9,6 @@ import { GooglePickerView } from '@uppy/provider-views'
 import type { PickedItem } from '@uppy/provider-views/lib/GooglePicker/googlePicker.js'
 import { GoogleDriveIcon } from '@uppy/provider-views/lib/GooglePicker/icons.js'
 import type { LocaleStrings } from '@uppy/utils/lib/Translator'
-import { h } from 'preact'
 
 import packageJson from '../package.json' with { type: 'json' }
 import locale from './locale.js'

packages/@uppy/google-photos-picker/src/GooglePhotosPicker.tsx

@@ -9,7 +9,6 @@ import { GooglePickerView } from '@uppy/provider-views'
 import type { PickedItem } from '@uppy/provider-views/lib/GooglePicker/googlePicker.js'
 import { GooglePhotosIcon } from '@uppy/provider-views/lib/GooglePicker/icons.js'
 import type { LocaleStrings } from '@uppy/utils/lib/Translator'
-import { h } from 'preact'
 
 import packageJson from '../package.json' with { type: 'json' }
 import locale from './locale.js'

packages/@uppy/image-editor/src/Editor.tsx

@@ -1,7 +1,7 @@
 import type { Body, Meta, UppyFile } from '@uppy/core'
 import type { I18n } from '@uppy/utils/lib/Translator'
 import Cropper from 'cropperjs'
-import { Component, h } from 'preact'
+import { Component } from 'preact'
 import type ImageEditor from './ImageEditor.js'
 import getCanvasDataThatFitsPerfectlyIntoContainer from './utils/getCanvasDataThatFitsPerfectlyIntoContainer.js'
 import getScaleFactorThatRemovesDarkCorners from './utils/getScaleFactorThatRemovesDarkCorners.js'

packages/@uppy/image-editor/src/ImageEditor.tsx

@@ -9,7 +9,6 @@ import type {
 import { UIPlugin } from '@uppy/core'
 import type { LocaleStrings } from '@uppy/utils/lib/Translator'
 import type Cropper from 'cropperjs'
-import { h } from 'preact'
 import packageJson from '../package.json' with { type: 'json' }
 import Editor from './Editor.js'
 import locale from './locale.js'

packages/@uppy/informer/src/FadeIn.tsx

@@ -1,4 +1,4 @@
-import { Component, type ComponentChild, createRef, h } from 'preact'
+import { Component, type ComponentChild, createRef } from 'preact'
 
 const TRANSITION_MS = 300
 

packages/@uppy/informer/src/Informer.tsx

@@ -1,6 +1,6 @@
 import type { Body, Meta, State, UIPluginOptions, Uppy } from '@uppy/core'
 import { UIPlugin } from '@uppy/core'
-import { type ComponentChild, h } from 'preact'
+import type { ComponentChild } from 'preact'
 import packageJson from '../package.json' with { type: 'json' }
 import FadeIn from './FadeIn.js'
 import TransitionGroup from './TransitionGroup.js'
@@ -37,7 +37,7 @@ export default class Informer<M extends Meta, B extends Body> extends UIPlugin<
               <p role="alert">
                 {info.message}{' '}
                 {info.details && (
-                  // biome-ignore lint/a11y/useKeyWithClickEvents: ...
+                  // biome-ignore lint/a11y/useKeyWithClickEvents: don't think it's needed
                   <span
                     aria-label={info.details as string}
                     data-microtip-position="top-left"

packages/@uppy/progress-bar/src/ProgressBar.tsx

@@ -7,7 +7,7 @@ import type {
   Uppy,
 } from '@uppy/core'
 import { UIPlugin } from '@uppy/core'
-import { type ComponentChild, h } from 'preact'
+import type { ComponentChild } from 'preact'
 
 import packageJson from '../package.json' with { type: 'json' }
 

packages/@uppy/provider-views/src/Breadcrumbs.tsx

@@ -1,5 +1,5 @@
 import type { Body, Meta, PartialTreeFolder } from '@uppy/core'
-import { Fragment, h } from 'preact'
+import { Fragment, type h } from 'preact'
 import type ProviderView from './ProviderView/index.js'
 
 type BreadcrumbsProps<M extends Meta, B extends Body> = {

packages/@uppy/provider-views/src/Browser.tsx

@@ -5,9 +5,7 @@ import type {
   PartialTreeFolderNode,
 } from '@uppy/core'
 import type { I18n } from '@uppy/utils/lib/Translator'
-// @ts-ignore untyped
 import VirtualList from '@uppy/utils/lib/VirtualList'
-import { h } from 'preact'
 import { useEffect, useState } from 'preact/hooks'
 import Item from './Item/index.js'
 import type ProviderView from './ProviderView/ProviderView.js'

packages/@uppy/provider-views/src/FooterActions.tsx

@@ -1,7 +1,6 @@
 import type { Body, Meta, PartialTree } from '@uppy/core'
 import type { I18n } from '@uppy/utils/lib/Translator'
 import classNames from 'classnames'
-import { h } from 'preact'
 import { useMemo } from 'preact/hooks'
 import type ProviderView from './ProviderView/ProviderView.js'
 import getNumberOfSelectedFiles from './utils/PartialTreeUtils/getNumberOfSelectedFiles.js'

packages/@uppy/provider-views/src/GooglePicker/GooglePickerView.tsx

@@ -1,6 +1,5 @@
 import type { AsyncStore, Uppy } from '@uppy/core'
 import type { I18n } from '@uppy/utils/lib/Translator'
-import { h } from 'preact'
 import { useCallback, useEffect, useRef, useState } from 'preact/hooks'
 import AuthView from '../ProviderView/AuthView.js'
 import {

packages/@uppy/provider-views/src/GooglePicker/icons.tsx

@@ -1,5 +1,3 @@
-import { h } from 'preact'
-
 export const GooglePhotosIcon = () => (
   <svg
     aria-hidden="true"

packages/@uppy/provider-views/src/Item/components/GridItem.tsx

@@ -1,5 +1,5 @@
 import type { PartialTreeFile, PartialTreeFolderNode } from '@uppy/core'
-import { h } from 'preact'
+import type { h } from 'preact'
 import ItemIcon from './ItemIcon.js'
 
 type GridItemProps = {

packages/@uppy/provider-views/src/Item/components/ItemIcon.tsx

@@ -1,4 +1,4 @@
-import { h } from 'preact'
+import type { h } from 'preact'
 
 function FileIcon() {
   return (

packages/@uppy/provider-views/src/Item/components/ListItem.tsx

@@ -3,7 +3,7 @@ import type {
   PartialTreeFolderNode,
   PartialTreeId,
 } from '@uppy/core'
-import { h } from 'preact'
+import type { h } from 'preact'
 import ItemIcon from './ItemIcon.js'
 
 // if folder:

packages/@uppy/provider-views/src/Item/index.tsx

@@ -5,7 +5,7 @@ import type {
 } from '@uppy/core'
 import type { I18n } from '@uppy/utils/lib/Translator'
 import classNames from 'classnames'
-import { h } from 'preact'
+import type { h } from 'preact'
 import GridItem from './components/GridItem.js'
 import ListItem from './components/ListItem.js'
 

packages/@uppy/provider-views/src/ProviderView/AuthView.tsx

@@ -1,6 +1,6 @@
 import type { Body, Meta } from '@uppy/core'
 import type { I18n } from '@uppy/utils/lib/Translator'
-import { h } from 'preact'
+import type { h } from 'preact'
 import { useCallback } from 'preact/hooks'
 import type ProviderViews from './ProviderView.js'
 import type { Opts } from './ProviderView.js'

packages/@uppy/provider-views/src/ProviderView/Header.tsx

@@ -1,7 +1,7 @@
 import type { Body, Meta, PartialTreeFolder } from '@uppy/core'
 import type { I18n } from '@uppy/utils/lib/Translator'
 import classNames from 'classnames'
-import { h } from 'preact'
+import type { h } from 'preact'
 import Breadcrumbs from '../Breadcrumbs.js'
 import type ProviderView from './ProviderView.js'
 import User from './User.js'

packages/@uppy/provider-views/src/ProviderView/ProviderView.tsx

@@ -14,7 +14,7 @@ import type { CompanionFile } from '@uppy/utils/lib/CompanionFile'
 import remoteFileObjToLocal from '@uppy/utils/lib/remoteFileObjToLocal'
 import type { I18n } from '@uppy/utils/lib/Translator'
 import classNames from 'classnames'
-import { h } from 'preact'
+import type { h } from 'preact'
 import packageJson from '../../package.json' with { type: 'json' }
 import Browser from '../Browser.js'
 import FooterActions from '../FooterActions.js'

packages/@uppy/provider-views/src/ProviderView/User.tsx

@@ -1,4 +1,4 @@
-import { Fragment, h } from 'preact'
+import { Fragment } from 'preact'
 
 type UserProps = {
   i18n: (phrase: string) => string

packages/@uppy/provider-views/src/SearchInput.tsx

@@ -1,5 +1,4 @@
 import { nanoid } from 'nanoid/non-secure'
-import { h } from 'preact'
 import type { ChangeEvent } from 'preact/compat'
 import { useCallback, useEffect, useState } from 'preact/hooks'
 

packages/@uppy/provider-views/src/SearchProviderView/SearchProviderView.tsx

@@ -13,7 +13,7 @@ import type { ValidateableFile } from '@uppy/core/lib/Restricter.js'
 import type { CompanionFile } from '@uppy/utils/lib/CompanionFile'
 import remoteFileObjToLocal from '@uppy/utils/lib/remoteFileObjToLocal'
 import classNames from 'classnames'
-import { h } from 'preact'
+import type { h } from 'preact'
 import packageJson from '../../package.json' with { type: 'json' }
 import Browser from '../Browser.js'
 import FooterActions from '../FooterActions.js'

packages/@uppy/react/src/headless/UppyContextProvider.tsx

@@ -5,13 +5,7 @@ import {
 } from '@uppy/components'
 import type Uppy from '@uppy/core'
 import type React from 'react'
-import {
-  createContext,
-  createElement as h,
-  useContext,
-  useEffect,
-  useState,
-} from 'react'
+import { createContext, useContext, useEffect, useState } from 'react'
 
 interface UppyContextValue {
   uppy: Uppy | undefined

packages/@uppy/react/src/headless/generated/Dropzone.tsx

@@ -7,7 +7,7 @@ import {
 } from '@uppy/components'
 import { h as preactH } from 'preact'
 import { render as preactRender } from 'preact/compat'
-import { createElement as h, useContext, useEffect, useRef } from 'react'
+import { useContext, useEffect, useRef } from 'react'
 import { UppyContext } from '../UppyContextProvider.js'
 
 export default function Dropzone(props: Omit<DropzoneProps, 'ctx'>) {

packages/@uppy/react/src/headless/generated/FilesGrid.tsx

@@ -7,7 +7,7 @@ import {
 } from '@uppy/components'
 import { h as preactH } from 'preact'
 import { render as preactRender } from 'preact/compat'
-import { createElement as h, useContext, useEffect, useRef } from 'react'
+import { useContext, useEffect, useRef } from 'react'
 import { UppyContext } from '../UppyContextProvider.js'
 
 export default function FilesGrid(props: Omit<FilesGridProps, 'ctx'>) {

packages/@uppy/react/src/headless/generated/FilesList.tsx

@@ -7,7 +7,7 @@ import {
 } from '@uppy/components'
 import { h as preactH } from 'preact'
 import { render as preactRender } from 'preact/compat'
-import { createElement as h, useContext, useEffect, useRef } from 'react'
+import { useContext, useEffect, useRef } from 'react'
 import { UppyContext } from '../UppyContextProvider.js'
 
 export default function FilesList(props: Omit<FilesListProps, 'ctx'>) {

packages/@uppy/react/src/headless/generated/ProviderIcon.tsx

@@ -7,7 +7,7 @@ import {
 } from '@uppy/components'
 import { h as preactH } from 'preact'
 import { render as preactRender } from 'preact/compat'
-import { createElement as h, useContext, useEffect, useRef } from 'react'
+import { useContext, useEffect, useRef } from 'react'
 import { UppyContext } from '../UppyContextProvider.js'
 
 export default function ProviderIcon(props: Omit<ProviderIconProps, 'ctx'>) {

packages/@uppy/react/src/headless/generated/Thumbnail.tsx

@@ -7,7 +7,7 @@ import {
 } from '@uppy/components'
 import { h as preactH } from 'preact'
 import { render as preactRender } from 'preact/compat'
-import { createElement as h, useContext, useEffect, useRef } from 'react'
+import { useContext, useEffect, useRef } from 'react'
 import { UppyContext } from '../UppyContextProvider.js'
 
 export default function Thumbnail(props: Omit<ThumbnailProps, 'ctx'>) {

packages/@uppy/react/src/headless/generated/UploadButton.tsx

@@ -7,7 +7,7 @@ import {
 } from '@uppy/components'
 import { h as preactH } from 'preact'
 import { render as preactRender } from 'preact/compat'
-import { createElement as h, useContext, useEffect, useRef } from 'react'
+import { useContext, useEffect, useRef } from 'react'
 import { UppyContext } from '../UppyContextProvider.js'
 
 export default function UploadButton(props: Omit<UploadButtonProps, 'ctx'>) {

packages/@uppy/screen-capture/src/DiscardButton.tsx

@@ -1,5 +1,5 @@
 import type { I18n } from '@uppy/utils/lib/Translator'
-import { h } from 'preact'
+import type { h } from 'preact'
 
 interface DiscardButtonProps {
   onDiscard: () => void

packages/@uppy/screen-capture/src/RecordButton.tsx

@@ -1,5 +1,5 @@
 import type { I18n } from '@uppy/utils/lib/Translator'
-import { h } from 'preact'
+import type { h } from 'preact'
 
 interface RecordButtonProps {
   recording: boolean | undefined

packages/@uppy/screen-capture/src/RecorderScreen.tsx

@@ -1,5 +1,5 @@
 import type { Body, Meta } from '@uppy/core'
-import { Component, type ComponentChild, Fragment, h } from 'preact'
+import { Component, type ComponentChild, Fragment } from 'preact'
 import DiscardButton from './DiscardButton.js'
 import RecordButton from './RecordButton.js'
 import type ScreenCapture from './ScreenCapture.js'

packages/@uppy/screen-capture/src/ScreenCapture.tsx

@@ -8,7 +8,7 @@ import type {
 import { UIPlugin } from '@uppy/core'
 import getFileTypeExtension from '@uppy/utils/lib/getFileTypeExtension'
 import type { LocaleStrings } from '@uppy/utils/lib/Translator'
-import { type ComponentChild, h } from 'preact'
+import type { ComponentChild } from 'preact'
 import packageJson from '../package.json' with { type: 'json' }
 import locale from './locale.js'
 import RecorderScreen from './RecorderScreen.js'

packages/@uppy/screen-capture/src/ScreenRecIcon.tsx

@@ -1,5 +1,3 @@
-import { h } from 'preact'
-
 export default function ScreenRecIcon() {
   return (
     <svg

packages/@uppy/screen-capture/src/ScreenshotButton.tsx

@@ -1,5 +1,3 @@
-import { h } from 'preact'
-
 interface ScreenshotButtonProps {
   onScreenshot: () => void
   i18n: (key: string) => string

packages/@uppy/screen-capture/src/StopWatch.tsx

@@ -1,4 +1,4 @@
-import { Component, h } from 'preact'
+import { Component } from 'preact'
 
 type $TSFixMe = any
 

packages/@uppy/screen-capture/src/StreamStatus.tsx

@@ -1,5 +1,3 @@
-import { h } from 'preact'
-
 type $TSFixMe = any
 
 export default function StreamStatus({ streamActive, i18n }: $TSFixMe) {

packages/@uppy/screen-capture/src/SubmitButton.tsx

@@ -1,5 +1,5 @@
 import type { I18n } from '@uppy/utils/lib/Translator'
-import { h } from 'preact'
+import type { h } from 'preact'
 
 interface SubmitButtonProps {
   recording: boolean

packages/@uppy/status-bar/src/Components.tsx

@@ -4,7 +4,6 @@ import type { FileProcessingInfo } from '@uppy/utils/lib/FileProgress'
 import prettyETA from '@uppy/utils/lib/prettyETA'
 import type { I18n } from '@uppy/utils/lib/Translator'
 import classNames from 'classnames'
-import { h } from 'preact'
 
 import statusBarStates from './StatusBarStates.js'
 

packages/@uppy/status-bar/src/StatusBar.tsx

@@ -10,7 +10,6 @@ import { UIPlugin } from '@uppy/core'
 import emaFilter from '@uppy/utils/lib/emaFilter'
 import getTextDirection from '@uppy/utils/lib/getTextDirection'
 import type { ComponentChild } from 'preact'
-import { h } from 'preact'
 import packageJson from '../package.json' with { type: 'json' }
 import locale from './locale.js'
 import type { StatusBarOptions } from './StatusBarOptions.js'

packages/@uppy/status-bar/src/StatusBarUI.tsx

@@ -1,7 +1,6 @@
 import type { Body, Meta, State, Uppy, UppyFile } from '@uppy/core'
 import type { I18n } from '@uppy/utils/lib/Translator'
 import classNames from 'classnames'
-import { h } from 'preact'
 import {
   CancelBtn,
   DoneBtn,

packages/@uppy/transloadit/src/index.test.js

@@ -77,13 +77,10 @@ describe('Transloadit', () => {
   })
 
   it('should complete when resuming after pause', async () => {
-    let assemblyCallCount = 0
     let firstUploadCallCount = 0
-    let secondUploadCallCount = 0
 
     const server = setupServer(
       http.post('*/assemblies', ({ request }) => {
-        assemblyCallCount++
         return HttpResponse.json({
           assembly_id: 'test-assembly-id',
           websocket_url: 'ws://localhost:8080',
@@ -107,7 +104,6 @@ describe('Transloadit', () => {
         })
       }),
       http.patch('*/resumable/files/*', () => {
-        secondUploadCallCount++
         return HttpResponse.json({
           ok: 'RESUMABLE_FILE_UPLOADED',
         })

packages/@uppy/url/src/Url.browser.test.ts

@@ -1,5 +1,5 @@
 import Uppy from '@uppy/core'
-import { page, userEvent } from '@vitest/browser/context'
+import { page } from '@vitest/browser/context'
 import { expect, test } from 'vitest'
 import Url from './Url.js'
 

packages/@uppy/url/src/UrlUI.tsx

@@ -1,6 +1,6 @@
 import type { I18n } from '@uppy/utils/lib/Translator'
 import { nanoid } from 'nanoid/non-secure'
-import { Component, type ComponentChild, h } from 'preact'
+import { Component, type ComponentChild } from 'preact'
 
 type UrlUIProps = {
   i18n: I18n

packages/@uppy/url/vitest.setup.ts

@@ -3,7 +3,7 @@ import { createServer } from 'node:http'
 import { dirname, join } from 'node:path'
 import { setTimeout } from 'node:timers/promises'
 import { fileURLToPath } from 'node:url'
-import { TestProject } from 'vitest/node'
+import type { TestProject } from 'vitest/node'
 
 const __filename = fileURLToPath(import.meta.url)
 const __dirname = dirname(__filename)

packages/@uppy/webcam/src/CameraIcon.tsx

@@ -1,4 +1,4 @@
-import { type ComponentChild, h } from 'preact'
+import type { ComponentChild } from 'preact'
 
 export default function CameraIcon(): ComponentChild {
   return (

packages/@uppy/webcam/src/CameraScreen.tsx

@@ -1,5 +1,5 @@
 import type { I18n } from '@uppy/utils/lib/Translator'
-import { Component, type ComponentChild, type ComponentProps, h } from 'preact'
+import { Component, type ComponentChild, type ComponentProps } from 'preact'
 import DiscardButton from './DiscardButton.js'
 import RecordButton from './RecordButton.js'
 import RecordingLength from './RecordingLength.js'
@@ -119,8 +119,9 @@ class CameraScreen extends Component<CameraScreenProps> {
           ) : (
             // eslint-disable-next-line jsx-a11y/media-has-caption
             <video
-              /* eslint-disable-next-line no-return-assign */
-              ref={(videoElement) => (this.videoElement = videoElement!)}
+              ref={(videoElement) => {
+                this.videoElement = videoElement!
+              }}
               className={`uppy-Webcam-video  ${
                 mirror ? 'uppy-Webcam-video--mirrored' : ''
               }`}

packages/@uppy/webcam/src/DiscardButton.tsx

@@ -1,5 +1,4 @@
 import type { I18n } from '@uppy/utils/lib/Translator'
-import { h } from 'preact'
 
 interface DiscardButtonProps {
   onDiscard: () => void

packages/@uppy/webcam/src/PermissionsScreen.tsx

@@ -1,5 +1,5 @@
 import type { I18n } from '@uppy/utils/lib/Translator'
-import { type ComponentChild, h } from 'preact'
+import type { ComponentChild } from 'preact'
 
 interface PermissionScreenProps {
   hasCamera: boolean

packages/@uppy/webcam/src/RecordButton.tsx

@@ -1,5 +1,4 @@
 import type { I18n } from '@uppy/utils/lib/Translator'
-import { h } from 'preact'
 
 interface RecordButtonProps {
   recording: boolean

packages/@uppy/webcam/src/RecordingLength.tsx

@@ -1,4 +1,3 @@
-import { h } from 'preact'
 import formatSeconds from './formatSeconds.js'
 
 interface RecordingLengthProps {

packages/@uppy/webcam/src/SnapshotButton.tsx

@@ -1,5 +1,4 @@
 import type { I18n } from '@uppy/utils/lib/Translator'
-import { h } from 'preact'
 import CameraIcon from './CameraIcon.js'
 
 interface SnapshotButtonProps {

packages/@uppy/webcam/src/SubmitButton.tsx

@@ -1,5 +1,4 @@
 import type { I18n } from '@uppy/utils/lib/Translator'
-import { h } from 'preact'
 
 interface SubmitButtonProps {
   onSubmit: () => void

packages/@uppy/webcam/src/VideoSourceSelect.tsx

@@ -1,4 +1,4 @@
-import { type ComponentChild, h } from 'preact'
+import type { ComponentChild } from 'preact'
 
 export interface VideoSourceSelectProps {
   currentDeviceId: string | MediaStreamTrack | null | undefined