mirror of
https://github.com/johannesjo/super-productivity.git
synced 2026-07-18 17:05:48 +00:00
77f83c5687
* test: harden e2e failure signals Fail otherwise-passing E2E tests on browser runtime errors, keep Playwright retries disabled, preserve Docker E2E exit codes, and make plugin/WebDAV setup failures hard failures instead of logged or skipped conditions. * test: harden provider e2e runners Make WebDAV and SuperSync runner scripts require provider readiness, preserve cleanup and argument forwarding, and fail manual sync clients on uncaught page errors. * ci: require providers for scheduled e2e Set required-provider flags in scheduled WebDAV and SuperSync jobs, and remove the duplicate provider runner scripts while keeping local npm aliases inline. * test: catch e2e teardown pageerrors and tighten fixture - closeClient now asserts runtime errors AFTER context.close() so pageerrors emitted during teardown (Angular destroy hooks, late RxJS errors) are captured instead of dropped. Matches the pattern in guardContextCloseWithRuntimeErrorCheck. - test.fixture.ts isolatedContext now spreads Playwright's merged contextOptions instead of destructuring 23 fields by hand. Future option additions propagate automatically; the page fixture uses the shared attachPageErrorCollector and only fails on pageerror (not console.error, which is too noisy). Guards against a configured 0 timeout being treated as undefined. - plugin-loading.spec.ts second test now hard-asserts that the plugin menu entry reappears after re-enable, matching the first test instead of silently logging when not visible. * test(sync): stabilize ImmediateUploadService spec Two complementary fixes for flaky failures observed under full-suite random-order runs where the upload pipeline silently never fires: - Pin navigator.onLine = true in beforeEach (restored in afterEach). isOnline() inside _canUpload reads navigator.onLine directly. The keyboard-layout spec replaces the whole navigator and the is-online spec spies on it; if order or restoration ever drifts, every "should fire upload" test fails trivially while the "should NOT" tests pass. - Replace tick(2100) with tick(2000); flush(). The await chain inside withSession() (provider.isReady, withSession entry, uploadPendingOps, optional LWW re-upload) requires more microtask drain than tick's fixed-time window reliably provides under load. flush() drains the pipeline regardless. * test(e2e): guard skipOnboarding init script against data: frames The new page-error collector started failing plugin specs because addInitScript runs in every frame — including the empty data:text/html iframe that plugin-index swaps in on destroy — and localStorage access in a data: URL throws SecurityError. Wrap the four setItem calls in try/catch so the helper noops in storage-less frames.
63 lines
1.4 KiB
TypeScript
63 lines
1.4 KiB
TypeScript
import type { BrowserContext, Page } from '@playwright/test';
|
|
|
|
export type RuntimeBrowserError = {
|
|
type: 'pageerror';
|
|
message: string;
|
|
};
|
|
|
|
export const attachPageErrorCollector = (
|
|
page: Page,
|
|
label: string,
|
|
): RuntimeBrowserError[] => {
|
|
const errors: RuntimeBrowserError[] = [];
|
|
|
|
page.on('pageerror', (error) => {
|
|
const message = error.stack ?? error.message;
|
|
console.error(`[${label}] Page error:`, message);
|
|
errors.push({
|
|
type: 'pageerror',
|
|
message,
|
|
});
|
|
});
|
|
|
|
return errors;
|
|
};
|
|
|
|
export const assertNoRuntimeBrowserErrors = (
|
|
errors: RuntimeBrowserError[],
|
|
label: string,
|
|
): void => {
|
|
if (errors.length === 0) {
|
|
return;
|
|
}
|
|
|
|
throw new Error(
|
|
`[${label}] Browser runtime errors were emitted during the test:\n${errors
|
|
.map((error, index) => `${index + 1}. ${error.type}: ${error.message}`)
|
|
.join('\n')}`,
|
|
);
|
|
};
|
|
|
|
export const guardContextCloseWithRuntimeErrorCheck = (
|
|
context: BrowserContext,
|
|
errors: RuntimeBrowserError[],
|
|
label: string,
|
|
): void => {
|
|
const originalClose = context.close.bind(context);
|
|
|
|
context.close = async (...args: Parameters<BrowserContext['close']>) => {
|
|
let closeError: unknown;
|
|
|
|
try {
|
|
await originalClose(...args);
|
|
} catch (error) {
|
|
closeError = error;
|
|
}
|
|
|
|
assertNoRuntimeBrowserErrors(errors, label);
|
|
|
|
if (closeError) {
|
|
throw closeError;
|
|
}
|
|
};
|
|
};
|