super-productivity/e2e/utils
Johannes Millan 77f83c5687
test(e2e): harden failure signals and provider gates (#7753)
* test: harden e2e failure signals

Fail otherwise-passing E2E tests on browser runtime errors, keep Playwright retries disabled, preserve Docker E2E exit codes, and make plugin/WebDAV setup failures hard failures instead of logged or skipped conditions.

* test: harden provider e2e runners

Make WebDAV and SuperSync runner scripts require provider readiness, preserve cleanup and argument forwarding, and fail manual sync clients on uncaught page errors.

* ci: require providers for scheduled e2e

Set required-provider flags in scheduled WebDAV and SuperSync jobs, and remove the duplicate provider runner scripts while keeping local npm aliases inline.

* test: catch e2e teardown pageerrors and tighten fixture

- closeClient now asserts runtime errors AFTER context.close() so
  pageerrors emitted during teardown (Angular destroy hooks, late RxJS
  errors) are captured instead of dropped. Matches the pattern in
  guardContextCloseWithRuntimeErrorCheck.
- test.fixture.ts isolatedContext now spreads Playwright's merged
  contextOptions instead of destructuring 23 fields by hand. Future
  option additions propagate automatically; the page fixture uses the
  shared attachPageErrorCollector and only fails on pageerror (not
  console.error, which is too noisy). Guards against a configured 0
  timeout being treated as undefined.
- plugin-loading.spec.ts second test now hard-asserts that the plugin
  menu entry reappears after re-enable, matching the first test instead
  of silently logging when not visible.

* test(sync): stabilize ImmediateUploadService spec

Two complementary fixes for flaky failures observed under full-suite
random-order runs where the upload pipeline silently never fires:

- Pin navigator.onLine = true in beforeEach (restored in afterEach).
  isOnline() inside _canUpload reads navigator.onLine directly. The
  keyboard-layout spec replaces the whole navigator and the is-online
  spec spies on it; if order or restoration ever drifts, every "should
  fire upload" test fails trivially while the "should NOT" tests pass.
- Replace tick(2100) with tick(2000); flush(). The await chain inside
  withSession() (provider.isReady, withSession entry, uploadPendingOps,
  optional LWW re-upload) requires more microtask drain than tick's
  fixed-time window reliably provides under load. flush() drains the
  pipeline regardless.

* test(e2e): guard skipOnboarding init script against data: frames

The new page-error collector started failing plugin specs because
addInitScript runs in every frame — including the empty data:text/html
iframe that plugin-index swaps in on destroy — and localStorage access
in a data: URL throws SecurityError. Wrap the four setItem calls in
try/catch so the helper noops in storage-less frames.
2026-05-23 20:33:04 +02:00
..
assertions.ts refactor(e2e): simplify improvements per KISS/YAGNI review 2026-01-06 12:46:20 +01:00
check-webdav.ts test(e2e): harden failure signals and provider gates (#7753) 2026-05-23 20:33:04 +02:00
config-helpers.ts fix(sync): harden vector clock sanitization and improve E2E test robustness 2026-02-12 16:27:56 +01:00
e2e-constants.ts perf(e2e): optimize polling intervals in helpers 2026-01-18 15:58:46 +01:00
element-helpers.ts refactor(e2e): extract ensureGlobalAddTaskBarOpen helper to reduce code duplication 2026-01-16 13:35:59 +01:00
index.ts feat(shepherd): remove all tours except keyboard navigation 2026-03-22 17:00:42 +01:00
legacy-migration-helpers.ts test(e2e): stabilize task visibility specs 2026-05-13 16:27:31 +02:00
runtime-errors.ts test(e2e): harden failure signals and provider gates (#7753) 2026-05-23 20:33:04 +02:00
schedule-task-helper.ts fix(e2e): fix schedule dialog submit button selector 2026-01-21 14:30:24 +01:00
supersync-assertions.ts test(e2e): fix failing WebDAV and SuperSync E2E tests 2026-03-23 11:07:25 +01:00
supersync-helpers.ts test(e2e): harden failure signals and provider gates (#7753) 2026-05-23 20:33:04 +02:00
sync-helpers.ts test(e2e): harden failure signals and provider gates (#7753) 2026-05-23 20:33:04 +02:00
time-input-helper.ts refactor(e2e): replace waitForTimeout with condition-based waits 2026-01-03 15:29:38 +01:00
waits.ts test(e2e): harden failure signals and provider gates (#7753) 2026-05-23 20:33:04 +02:00