mirror of
https://github.com/johannesjo/super-productivity.git
synced 2026-07-18 00:46:45 +00:00
3d0ff2aec7
Folds the six-Claude-lens (correctness, security/privacy, architecture, alternatives, performance, simplicity) review pass into the SuperSync slice design doc. Closes all 8 open questions in-doc, records new blockers the original draft undercounted, and trims the body per the simplicity reviewer's recommendations. Key revisions: - Storage port is narrow `SuperSyncStorage` (3 methods), not the generic `KeyValueStoragePort` originally proposed. Architecture and alternatives both pushed back. - Promoted helper renamed to `isRetryableUploadError` (intent- anchored) to avoid naming collision with package's existing `isTransientNetworkError`. - Factory drops `extraPath` — SuperSync explicitly ignores it. - Privacy A1 fix uses extracted-reason form (via `_extractServerErrorReason`, capped at 80 chars), not blanket body-drop — preserves 5xx debug context. Four new privacy blockers added that the original sweep missed: - `AuthFailSPError(reason, body)` retains body via `AdditionalLogErrorBase.additionalLog` (security + correctness both flagged independently — PR 5b did NOT scrub this for SuperSync's call site). - `_handleNativeRequestError` re-throw embeds raw `errorMessage` (can leak hostname/URL from native-stack `.message`). - Timeout `Error.message` embeds `path` with `excludeClient` query param (pseudonymous clientId). - `_extractServerErrorReason` returns server `error` field uncapped. Dissents recorded: alternatives reviewer preferred pre-split spec before move, moving CompressError/DecompressError into sync-core for strict behavior preservation, and barrel split as PR 7d. |
||
|---|---|---|
| .. | ||
| long-term-plans | ||
| plans | ||
| promotion | ||
| research | ||
| screens | ||
| sync-and-op-log | ||
| wiki | ||
| add-new-integration.md | ||
| build-and-publish-notes.md | ||
| documentation-guide.md | ||
| ENV_SETUP.md | ||
| github-access-token-instructions.md | ||
| gitlab-access-token-instructions.md | ||
| how-to-rate.md | ||
| howto-refresh-snap-credentials.md | ||
| i18n-script-usage.md | ||
| legacy-webview-analysis.md | ||
| mac-app-store-code-signing-guide.md | ||
| performance-project-tag-report.md | ||
| plugin-development.md | ||
| styling-guide.md | ||
| theming-contract.md | ||
| TRANSLATING.md | ||
| unused-translations-analysis.md | ||
| update-android-app.md | ||
| update-mac-certificates.md | ||