Commit graph

22 commits

Author SHA1 Message Date
Johannes Millan
dbeca43876 test(e2e): fix done-toggle selector to use element instead of class
The done-toggle was refactored from an inline SVG with class="done-toggle"
into a standalone Angular component <done-toggle>. Update all e2e selectors
from '.done-toggle' (class) to 'done-toggle' (element) to match.
2026-03-24 16:25:42 +01:00
Johannes Millan
31480a5fab feat(tasks): replace drag handle with done toggle circle and improve mobile UX
- Replace drag handle with SVG done-toggle circle with checkmark draw-on animation
- Improve mobile UX: cdkDragStartDelay for touch, bottom-sheet context menu
- Move issue/repeat indicators from drag handle to tag-list as chips
- Add isFinishDayEnabled config toggle
- Reorder context menu: add sub task before duplicate, deadline as own entry
- Fix context menu not opening on swipe left
- Fix race condition in done toggle animation timeout
2026-03-22 18:14:16 +01:00
Johannes Millan
1a0e38fb17 test(e2e): use correct route /#/tag/TODAY/tasks instead of /#/tag/TODAY
The deadlines feature commit accidentally reverted e2e URL fixes.
The route /#/tag/TODAY has no default child component — only
/#/tag/TODAY/tasks renders the work view with task-list.
2026-03-15 18:48:00 +01:00
Johannes Millan
d401e6169e feat(tasks): add deadlines feature with reminders and planner integration
Add deadline support for tasks with date-only and time-specific deadlines.

Core:
- Add deadlineDay, deadlineWithTime, deadlineRemindAt fields to task model
- Add NgRx actions (setDeadline, removeDeadline, clearDeadlineReminder)
- Add meta-reducer with mutual exclusivity and input validation
- Register deadline actions in ActionType enum and op-log codes

UI:
- Create deadline dialog with calendar, time input, and reminder options
- Add deadline badge to task list row with overdue warning color
- Add deadline item to task detail panel with flag icon
- Add deadline options to task context menu
- Show deadlines in scheduled list page

Reminders:
- Add deadline reminder effects and selectors
- Show reminder dialog with grouped deadline/schedule sections
- Handle deadline reminder clearing on dismiss, done, add-to-today
- Cancel Android native deadline notifications on delete/archive

Planner:
- Show deadline tasks in planner day view and overdue section
- Create dedicated planner-deadline-task component
- Optimize deadline grouping with O(N) single-pass selector

Other:
- Add deadline-today banner effect for unplanned deadline tasks
- Add translation keys for all deadline UI strings
- Add E2E tests for deadline reminder flows
- Add unit tests for deadline reducer and overdue utility
- Extract shared isDeadlineOverdue utility function
- Guard app-state selectors against undefined during teardown
2026-03-15 18:48:00 +01:00
Johannes Millan
80c178cf03 test(e2e): use correct route /#/tag/TODAY/tasks instead of /#/tag/TODAY
The route /#/tag/TODAY has no default child component — only sub-routes
like /worklog, /quick-history render content. The /tasks route is defined
as a separate eagerly-loaded route, not as a child of /tag/:id. Navigating
to /#/tag/TODAY leaves an empty router-outlet, causing 6 test failures
and 1 flaky test.
2026-03-13 19:33:17 +01:00
Johannes Millan
80540d8371 test(e2e): add detail panel focus sync tests (#6578) 2026-02-21 11:29:44 +01:00
Johannes Millan
b834bbedb1 test(e2e): fix 12 flaky tests by removing networkidle waits and fixing plugin setup
Replace unreliable waitForLoadState('networkidle') with element-based waits
in planner page and tests. Fix plugin helper timeout math bugs and eliminate
duplicate settings navigation in plugin tests. Improve menu overlay cleanup
and increase tight timeouts in migration and work-view tests.
2026-02-09 17:55:12 +01:00
Johannes Millan
cbc36012d8 test(e2e): fix add-to-today subtask tests
- Add Escape key press after creating subtasks to force exit from edit mode
- Simplify first test to remove both parent and subtask from Today, then use keyboard shortcut (most reliable)
- Fix context menu test to click sun icon button in quick-access area instead of searching for text
- Simplify "should NOT add subtask" test to avoid unreliable task counting
- Add proper wait times for Angular change detection cycles

All 5 tests now passing consistently.
2026-01-16 22:34:50 +01:00
Johannes Millan
0e0c04915c fix(tasks): prevent dueDay update on filtered subtasks in planTasksForToday
Fixes bug where planTasksForToday was setting dueDay on all taskIds,
including subtasks that were filtered out from being added to TODAY_TAG
(e.g., subtasks whose parents are already in Today). This caused state
inconsistencies where subtasks would have today's dueDay but not be in
the TODAY_TAG.

Now only updates dueDay for tasks that are either:
1. Being added to TODAY_TAG (newTasksForToday), OR
2. Already in TODAY_TAG but have incorrect dueDay

Also improves E2E test selectors:
- Use proper DOM structure (.task-list-inner > task)
- Add hover timeout for Angular change detection
- Fix context menu selector to use Material menu pattern
2026-01-16 22:34:50 +01:00
Johannes Millan
6087b63878 fix(tasks): add subtasks to Today via Add to Today button
Fixes issue where clicking "Add to Today" button or using Ctrl+T
keyboard shortcut on subtasks had no effect. The action dispatch
was missing the parentTaskMap parameter needed by the reducer to
properly handle parent-child task relationships.

- Add parentTaskMap to planTasksForToday action in task.component.ts
- Add parentTaskMap to planTasksForToday action in task-context-menu
- Add comprehensive unit tests for subtask scenarios
- Add E2E tests for button, keyboard shortcut, and context menu

Fixes #6028
2026-01-16 22:34:50 +01:00
Johannes Millan
b544131921 refactor(e2e): improve 2026-01-06 12:46:20 +01:00
Johannes Millan
11d85208e5 refactor(e2e): replace waitForTimeout with condition-based waits
- Replace ~100 waitForTimeout calls with proper condition-based waits
- Extract shared utilities for time input and task scheduling
- Add timeout constants for consistent wait times
- Add new selectors for reminder dialogs and detail panels

Files refactored across 25+ test files including:
- Plugin tests (lifecycle, upload, loading, enable, structure)
- Reminder tests (view-task, schedule-page, default-options)
- Work view, planner, focus mode, and app feature tests
- Task dragdrop, autocomplete, and daily summary tests

New utilities created:
- e2e/utils/time-input-helper.ts - Robust time input filling
- e2e/utils/schedule-task-helper.ts - Task scheduling helpers
- e2e/constants/timeouts.ts - Standardized timeout values
2026-01-03 15:29:38 +01:00
Johannes Millan
ecdd06988a test(e2e): improve e2e stability 2025-11-06 19:54:50 +01:00
Johannes Millan
4e0595d8b8 test(e2e): fix 2025-10-24 13:57:22 +02:00
Johannes Millan
ea1440a9cf test: e2e make more stable 2025-09-12 21:15:51 +02:00
Johannes Millan
b20f845cb9 test(e2e): make all e2e tests work again and optimize 2025-09-09 23:47:34 +02:00
Johannes Millan
31f269adef test: make e2e work again 2025-08-24 19:46:39 +02:00
Johannes Millan
913278f703 test(e2e): reduce logs 2025-08-08 19:20:24 +02:00
Johannes Millan
1a82aa905b test(e2e): improve 2025-08-04 18:35:00 +02:00
Johannes Millan
613ccfa3da test(e2e): restore all test files from 4781b6ec with updated import paths 2025-08-02 16:57:12 +02:00
Johannes Millan
6ddbf00651 test(e2e): remove console.log statements and replace console.error with throw
- Remove all console.log statements from E2E test files
- Replace console.error with throw new Error for proper error handling
- Remove console.warn statements
- Fix unused variable linting errors in plugin tests
2025-08-02 12:25:21 +02:00
Johannes Millan
9f2c786e41 refactor: move tests 2025-08-02 11:37:25 +02:00