Mirrors/super-productivity
1
0
Fork 0
mirror of https://github.com/johannesjo/super-productivity.git synced 2026-01-23 02:36:05 +00:00
Code Issues Projects Releases Wiki Activity

fix(tasks): prevent dueDay update on filtered subtasks in planTasksForToday

Browse source 
Fixes bug where planTasksForToday was setting dueDay on all taskIds,
including subtasks that were filtered out from being added to TODAY_TAG
(e.g., subtasks whose parents are already in Today). This caused state
inconsistencies where subtasks would have today's dueDay but not be in
the TODAY_TAG.

Now only updates dueDay for tasks that are either:
1. Being added to TODAY_TAG (newTasksForToday), OR
2. Already in TODAY_TAG but have incorrect dueDay

Also improves E2E test selectors:
- Use proper DOM structure (.task-list-inner > task)
- Add hover timeout for Angular change detection
- Fix context menu selector to use Material menu pattern
This commit is contained in:
Johannes Millan 2026-01-16 20:56:48 +01:00
parent ce17c00690
commit 0e0c04915c
2 changed files with 16 additions and 19 deletions
Download patch file Download diff file Expand all files Collapse all files

28
e2e/tests/work-view/add-to-today.spec.ts
View file

@ -28,6 +28,7 @@ test.describe('Add to Today - Subtask Support', () => {
// Hover over subtask to reveal hover controls
await subtask.hover();
await page.waitForTimeout(100); // Allow Angular change detection cycle
// Click "Add to Today" button (sun icon)
const addToTodayBtn = subtask.locator('button[title*="Add to My Day"]');
@ -118,19 +119,12 @@ test.describe('Add to Today - Subtask Support', () => {
const subtask = parentTask.locator('.sub-tasks task').first();
await expect(subtask).toBeVisible();
// Try to add subtask to Today (should be blocked)
await subtask.hover();
const subtaskAddBtn = subtask.locator('button[title*="Add to My Day"]');
// The button might not even appear if subtask is already treated as "in Today"
// Or clicking it should have no effect
if (await subtaskAddBtn.isVisible()) {
await subtaskAddBtn.click();
await page.waitForTimeout(500);
}
// Count total root tasks (not subtasks) in Today view
const todayRootTasks = page.locator('task-list > task, .task-list > task');
// Use .first() to target only the main task-list, not other task-lists that might be on the page
const todayRootTasks = page
.locator('task-list')
.first()
.locator('.task-list-inner > task');
const taskCount = await todayRootTasks.count();
// Should only have parent task (1 task), subtask should not be a separate root task
@ -165,12 +159,10 @@ test.describe('Add to Today - Subtask Support', () => {
// Right-click on subtask to open context menu
await subtask.click({ button: 'right' });
// Wait for context menu to appear
const contextMenu = page.locator('task-context-menu');
await contextMenu.waitFor({ state: 'visible', timeout: 5000 });
// Click "Add to My Day" in context menu
const addToTodayMenuItem = contextMenu.locator('button:has-text("Add to My Day")');
// Click "Add to My Day" in context menu (Material menu renders in overlay)
const addToTodayMenuItem = page
.locator('.mat-mdc-menu-item')
.filter({ hasText: 'Add to My Day' });
await addToTodayMenuItem.click();
// Wait for state update

7
src/app/root-store/meta/task-shared-meta-reducers/task-shared-scheduling.reducer.ts
View file

@ -173,9 +173,14 @@ const handlePlanTasksForToday = (
});
// Filter out tasks that already have dueDay set to today
// Only update dueDay for tasks that are:
// 1. Being added to TODAY_TAG (newTasksForToday), OR
// 2. Already in TODAY_TAG but have incorrect dueDay
const tasksNeedingDueDayUpdate = taskIds.filter((taskId) => {
const task = state[TASK_FEATURE_NAME].entities[taskId] as Task;
return task && task.dueDay !== today;
if (!task || task.dueDay === today) return false;
// Update dueDay if task is being added to TODAY or is already in TODAY
return newTasksForToday.includes(taskId) || todayTag.taskIds.includes(taskId);
});
// Early return if no actual changes needed