Commit graph

296 commits

Author SHA1 Message Date
Till Maas
b445c04ea7
Merge pull request #114 from tyll/unittests
Cleanup/prepare unit tests for ethtool option support
2019-06-07 09:53:14 +02:00
Till Maas
ab60a47475 connections unit tests: Introduce ETHERNET_DEFAULTS 2019-06-06 22:24:34 +02:00
Till Maas
4ad865af8a Argument validator: generate Ethernet defaults 2019-06-06 22:07:40 +02:00
Till Maas
d2e7af451e connections unit tests: Fix sys.path manipulation
After moving the unit tests into a subdirectory, the path inserts need
to go to one more parent directory.
2019-06-06 21:44:36 +02:00
Till Maas
72cc26a568
Merge pull request #111 from tyll/unittests
Reorganize unit tests
2019-06-06 12:11:50 +02:00
Till Maas
9e5150b88d tests_unit.yml: Fix ansible-lint warnings 2019-06-06 09:06:16 +02:00
Till Maas
0cbf94af61 unitests: Move unit tests in separate directory 2019-06-06 09:06:16 +02:00
Till Maas
058eb4d1cd tests: Add missing roles symlink 2019-06-06 09:06:12 +02:00
Till Maas
8ec0196781 tests: Test setting the MTU of VLAN interfaces
Test setting the MTU interfaces. This needs autoconnect:false for now,
possibly because of a bug in NetworkManager.
2019-06-03 11:28:07 +02:00
Till Maas
5fa8ac9c2c
Merge pull request #109 from tyll/tests_states
tests: Test volatile state changes
2019-05-28 10:41:09 +02:00
Till Maas
1d342ef037 tests: Test volatile state changes 2019-05-26 21:19:23 +02:00
Till Maas
a4a3373e3f
Merge pull request #107 from vcrhonek/molecule-travis
Configure Molecule in Travis CI
2019-05-06 17:07:06 +02:00
Till Maas
f9fff1776d tox: Use custom selinux shim
Travis uses Ubuntu which is not yet supported by the python selinux
shim. Use a custom fork instead.
2019-05-06 11:08:44 +02:00
Till Maas
2da9e46d16 Travis: Use python 3.5 for molecule
Python 3.5 is the native python version in Ubuntu Xenial:
https://packages.ubuntu.com/xenial/python3
2019-05-06 11:08:44 +02:00
Till Maas
48d17d44b3 Run molecule with tox 2019-05-06 11:08:44 +02:00
Vitezslav Crhonek
de194e7833 Add molecule configuration 2019-05-06 11:08:44 +02:00
Till Maas
0d09e0b8e2
Merge pull request #108 from tyll/yamlcleanup
Cleanup yaml in preparation for molecule testing
2019-05-06 11:08:06 +02:00
Till Maas
0c59fe1c6a Cleanup yaml files for molecule lint 2019-04-25 14:19:15 +02:00
Till Maas
a2380ece03 meta: Update distribution versions 2019-04-25 14:15:08 +02:00
Till Maas
d7152a5502 meta: Update Author 2019-04-25 14:15:08 +02:00
Till Maas
cb612b07c5
Merge pull request #106 from tyll/travis_new
travis: Test against more python versions
2019-04-25 14:14:11 +02:00
Till Maas
1ec39050ff travis: Test against more python versions 2019-04-25 13:23:34 +02:00
Till Maas
baf881ec3a
Merge pull request #105 from tyll/container_support
More container improvements/cleanups
2019-04-16 21:45:14 +02:00
Till Maas
bfeed7d6cb tasks: Address yamllint/ansible-lint issues 2019-04-16 20:37:35 +02:00
Till Maas
fb3cd7cccc tasks: Do initscripts workaround only for initscripts 2019-04-16 20:34:57 +02:00
Till Maas
344305fd8f tests: Cleanup unit tests playbook 2019-04-16 18:27:45 +02:00
Till Maas
eef5ea350f tests: Do not follow local symlinks
A symlink like

ansible -> ../..

in module_utils/network_lsr breaks the copy task with a strange error
message:

An exception occurred during task execution. To see the full traceback,
use -vvv. The error was: FileNotFoundError: [Errno 2] No such file or
directory: ''

Avoiding following symlinks helps here. The symlink makes it easier to
import the files since the import paths include ansible as a component:

from ansible.module_utils.network_lsr.utils import Util
2019-04-16 18:27:45 +02:00
Till Maas
00a81165e8 tests: Install iproute to manage test interfaces 2019-04-16 18:27:45 +02:00
Till Maas
f8d325f9fa tests: Adjust profile path if necessary
If /etc/network-scripts does no exist, NeworkManger uses
/etc/NetworkManager/system-connections to store profiles. Use this
directory if necessary.
2019-04-16 18:27:45 +02:00
Till Maas
5273f55166 tests: Do not use ansible_interfaces
ansible_interfaces requires iproute to be present which might not be the
case for container images. Check /sys/class/net to avoid the dependency.
2019-04-16 18:27:45 +02:00
Till Maas
7b503a3862
Merge pull request #104 from tyll/container_support
Initscripts workarounds
2019-04-15 21:21:38 +02:00
Till Maas
1b95e02b98 tasks/initscripts: Create /etc/sysconfig/network
The initscripts network service requires /etc/sysconfig/network to be
present. The file might be missing in container images, for example
currently in CentOS 7. It seems to be created by anaconda usually.
Therefore just create it if necessary as it can be empty.

References:
https://bugs.centos.org/view.php?id=16010
2019-04-15 17:35:08 +02:00
Till Maas
25181ed5b7 tasks/initscripts: Do not start network service
The network service from initscripts fails if there are network profiles
for unknown devices. Also it does not start an actual daemon but just
activates all profiles on disk. Therefore only enable it to ensure it
will come up after boot.
2019-04-15 17:34:51 +02:00
Till Maas
74b3a31f90
Merge pull request #101 from linux-system-roles/th/nm-connection-type
[th/nm connection-type] fix creating vlan and mac profiles for NetworkManager
2019-02-08 09:58:38 +01:00
Thomas Haller
7157713b14 module: fix setting NM connection-type for "vlan" and "macvlan"
Otherwise:

  failure: created connection failed to normalize: nm-connection-error-quark:
  connection.type: property is missing (6)
2019-02-08 07:30:54 +01:00
Thomas Haller
cff6989606 module: use introspection variables instead of plain strings for setting names 2019-02-08 07:30:54 +01:00
Till Maas
f5ee8a7e1c
Merge pull request #95 from tyll/update2
Make connections volatile instead of removing them
2019-01-10 22:11:09 +01:00
Till Maas
0d4beae1b8
Merge pull request #94 from tyll/less_noise
tasks: Do not log full service facts
2019-01-10 22:10:49 +01:00
Till Maas
c0b7605c4f
Merge pull request #96 from tyll/generate_fix
Tests: Only show missing test files when checking
2019-01-10 20:21:59 +01:00
Thomas Haller
d2ce509320 module: rework polling in NMUtil.wait_till_connection_is_gone()
time.sleep() does not sleep an exact amount of time, hence, adding
up the sleep-times will not give the exact total wait-time.
An alternative would be to take a CLOCK_BOOTTIME timestamp (or similar)
and determine the elapsed time based on that.

Instead, do something different, and use a GLib timeout for polling.
2019-01-10 14:39:15 +01:00
Thomas Haller
c0b2430144 module: minor cleanup of Util.GMainLoop_run()
It was rather confusing whether the boolean return value meant
that the timeout was reached or the opposite.

Rename the internal variable, I think now it's quite clear.
2019-01-10 14:39:15 +01:00
Till Maas
1ca27dc09c Clarify missing type error 2019-01-10 14:39:15 +01:00
Till Maas
6fc00a0d43 Make connections volatile instead of removing them
This keeps the profile up in Network Manager for
persistent_state:absent.
2019-01-10 14:39:15 +01:00
Till Maas
16f06b18a8 Tests: Only show missing test files when checking 2019-01-09 22:59:27 +01:00
Till Maas
2f605ea8df tasks: Do not log full service facts
The service facts create too much noise in test logs, therefore hide
them.
2019-01-09 22:52:27 +01:00
Till Maas
9314a2b251
Merge pull request #93 from tyll/asserts
test asserts: Clarify name
2019-01-08 20:52:28 +01:00
Till Maas
a1d258d9dc
Merge pull request #91 from tyll/name_other_provider_tasks
Tests: Add names for other provider tasks/playbooks
2019-01-08 20:52:00 +01:00
Till Maas
9b3712cbdf test asserts: Clarify name 2019-01-08 17:11:38 +01:00
Till Maas
4d9f475ce7 Tests: Add names for other provider tasks/playbooks 2019-01-08 17:10:31 +01:00
Pavel Cahyna
b144a026b4 Add Fedora 29 support to Galaxy metadata 2018-11-14 15:53:32 +01:00