There are a few problems with the NPM commitlint
* NPM is problematic
* Having to install NPM and commitlint and dependencies is slow and heavyweight
* commitlint is overkill for our simple use case
We have our own pr_title_lint.py which is small and works exactly for our use case.
Enhance coderabbit checks for PRs and test cleanup
Signed-off-by: Rich Megginson <rmeggins@redhat.com>
The method for determining the kernel url path for the module did not
work on all arches.
Skip the test if the kernel module is not found. Some architectures do
not provide the module.
Signed-off-by: Rich Megginson <rmeggins@redhat.com>
We do not use molecule.
The custom requirements are no longer needed.
Remove py26 requirements
Use ansible-core - much smaller than ansible
Signed-off-by: Rich Megginson <rmeggins@redhat.com>
The wireless test setup/cleanup had a lot of duplicated code scattered
among a few task files. This unifies the setup and cleanup code and
gets rid of redundant files.
This also enables all of the wireless tests on CentOS 7 and later,
and RHEL 8 and later.
Signed-off-by: Rich Megginson <rmeggins@redhat.com>
Cause: The retry loop for reading from a device would bail out of the loop
before retrying because the loop should have used a greater-than-or-equal
to test the retry condition rather than a less-than.
Consequence: If the device is not stable, the loop would bail and issue
an exception rather than trying to retry the read.
Fix: Use the correct loop condition.
Result: The network role can correctly retry the read when the device
is unstable.
Signed-off-by: Rich Megginson <rmeggins@redhat.com>
- Add info about .coderabbit.yam for AI assistants to contributing.md
- Note that CodeRabbit uses config from the main branch so this change will apply
after this PR is merged.
Signed-off-by: Sergei Petrosian <spetrosi@redhat.com>
The recently released ansible.posix 2.2.0 does not work on EL7.
Pin the version of ansible.posix to 2.1.X.
NOTE: Even though this role might not support EL7, this update
is applied to all system roles for consistency. Plus, when this
role is part of the system roles collection, all roles must use
the same version of ansible.posix - there is no way for a role
which is part of a collection to use a different version of a
dependency than the version used by the other roles.
Signed-off-by: Rich Megginson <rmeggins@redhat.com>
Sourcery that we currently use cannot read documentation files and best
practices, it's rather a refactoring tool.
So I want to introduce CodeRabbit that allows creating .coderabbit.yaml with
custom rules and conventions.
Signed-off-by: Sergei Petrosian <spetrosi@redhat.com>
- Replace no_log: true with no_log: "{{ ansible_verbosity < 3 }}"
in all tasks (setup, service_facts, package_facts, and service tasks)
- This allows output to be shown when running with -vvv or higher verbosity
- The no_log was used for verbosity control, not security purposes
In the network role, no_log: true was used to reduce verbose output,
not to protect sensitive information. Using ansible_verbosity allows
users to see the output when debugging with increased verbosity flags.
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Signed-off-by: Sergei Petrosian <spetrosi@redhat.com>
If you set __network_debug_flags=log-to-syslog then the internal trace messages which
are returned by the module will also be logged to syslog. This is useful for when
the network role hangs and times out and is killed before those messages can
be returned. The trace messages printed to syslog can help debug problems.
Signed-off-by: Rich Megginson <rmeggins@redhat.com>
Refactor the common code in tests_unit.yml and the integration pytest
into a single block of code.
The tests/ directory has a library sub-directory with a symlink to the
network_connections.py module. This was causing problems because the logic
in get_modules_and_utils_paths.yml really wants the real files and
directories, not the symlinks, and for some reason the bash `-f` test
is returning `true` for the symlink. Instead, ensure that we do not use
the link by using `-L` to screen it out.
Also added the collection paths to the search.
Make the path arrays have unique values.
Use the `realpath` filter to see the full actual path.
Signed-off-by: Rich Megginson <rmeggins@redhat.com>
Feature: Add a fingerprint string to the system log to indicate when the role began
successfully, and when the role finished successfully. The fingerprint string indicates
the role name, a timestamp, and the platform.
Reason: Users can see when the role was used and if it was used successfully. This
information from the system log can be collected by log scanners and aggregators
for further analysis.
Result: The role logs fingerprints to the system log.
This also adds a test to check if the fingerprints were written upon a successful
role invocation.
Signed-off-by: Rich Megginson <rmeggins@redhat.com>
ansible-lint requires the dependencies in meta/collection-requirements.yml
and tests/collection-requirements.yml to be installed. tox-lsr 3.18.1
will ensure they are installed.
Refactor the tests somewhat so that the collection and test steps are separate.
Signed-off-by: Rich Megginson <rmeggins@redhat.com>
https://github.com/ansible-collections/partner-certification-checker/blob/main/README.md
Unfortunately we cannot use the checkers provided by their team because they assume
the git repo is in collection format - you cannot convert to collection format first
then point the checkers at that collection. Instead, implement our own checkers that
do the same (and more) - check with multiple versions of ansible-lint and ansible-test
to ensure we cover:
* all supported versions of EL
* Automation Hub gating
* the latest versions of Ansible, including the latest milestone version
This requires the latest version of tox-lsr
Signed-off-by: Rich Megginson <rmeggins@redhat.com>
