mirror of
https://github.com/johnkerl/miller.git
synced 2026-07-17 16:38:54 +00:00
Replaces 100+ if/else-if chains on a single variable with tagged switch statements across 72 files. The bulk are transformer option-parsing loops (switch on opt string), plus a handful of value-dispatch sites in mlrval, dsl/cst, repl, lib, auxents, and bifs. One case (surv.go) required a labeled break to preserve the loop-exit behavior of the original else branch. Fixes staticcheck QF1003 findings. Co-authored-by: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
226 lines
6.2 KiB
Go
226 lines
6.2 KiB
Go
package transformers
|
|
|
|
import (
|
|
"fmt"
|
|
"os"
|
|
"strings"
|
|
|
|
"github.com/johnkerl/miller/v6/pkg/cli"
|
|
"github.com/johnkerl/miller/v6/pkg/mlrval"
|
|
"github.com/johnkerl/miller/v6/pkg/types"
|
|
)
|
|
|
|
const verbNameFillDown = "fill-down"
|
|
|
|
var FillDownSetup = TransformerSetup{
|
|
Verb: verbNameFillDown,
|
|
UsageFunc: transformerFillDownUsage,
|
|
ParseCLIFunc: transformerFillDownParseCLI,
|
|
IgnoresInput: false,
|
|
}
|
|
|
|
func transformerFillDownUsage(
|
|
o *os.File,
|
|
) {
|
|
fmt.Fprintf(o, "Usage: %s %s [options]\n", "mlr", verbNameFillDown)
|
|
fmt.Fprintln(o, "If a given record has a missing value for a given field, fill that from")
|
|
fmt.Fprintln(o, "the corresponding value from a previous record, if any.")
|
|
fmt.Fprintln(o, "By default, a 'missing' field either is absent, or has the empty-string value.")
|
|
fmt.Fprintln(o, "With -a, a field is 'missing' only if it is absent.")
|
|
fmt.Fprintln(o, "")
|
|
fmt.Fprintln(o, "Options:")
|
|
fmt.Fprintln(o, " --all Operate on all fields in the input.")
|
|
fmt.Fprintln(o, " -a|--only-if-absent If a given record has a missing value for a given field,")
|
|
fmt.Fprintln(o, " fill that from the corresponding value from a previous record, if any.")
|
|
fmt.Fprintln(o, " By default, a 'missing' field either is absent, or has the empty-string value.")
|
|
fmt.Fprintln(o, " With -a, a field is 'missing' only if it is absent.")
|
|
fmt.Fprintln(o, " -f Field names for fill-down.")
|
|
fmt.Fprintln(o, " -h|--help Show this message.")
|
|
}
|
|
|
|
func transformerFillDownParseCLI(
|
|
pargi *int,
|
|
argc int,
|
|
args []string,
|
|
_ *cli.TOptions,
|
|
doConstruct bool, // false for first pass of CLI-parse, true for second pass
|
|
) (RecordTransformer, error) {
|
|
|
|
// Skip the verb name from the current spot in the mlr command line
|
|
argi := *pargi
|
|
verb := args[argi]
|
|
argi++
|
|
|
|
var fillDownFieldNames []string = nil
|
|
doAll := false
|
|
onlyIfAbsent := false
|
|
|
|
var err error
|
|
for argi < argc /* variable increment: 1 or 2 depending on flag */ {
|
|
opt := args[argi]
|
|
if !strings.HasPrefix(opt, "-") {
|
|
break // No more flag options to process
|
|
}
|
|
if args[argi] == "--" {
|
|
break // All transformers must do this so main-flags can follow verb-flags
|
|
}
|
|
argi++
|
|
|
|
switch opt {
|
|
case "-h", "--help":
|
|
transformerFillDownUsage(os.Stdout)
|
|
return nil, cli.ErrHelpRequested
|
|
|
|
case "-f":
|
|
fillDownFieldNames, err = cli.VerbGetStringArrayArg(verb, opt, args, &argi, argc)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
case "--all":
|
|
doAll = true
|
|
|
|
case "-a", "--only-if-absent":
|
|
onlyIfAbsent = true
|
|
|
|
default:
|
|
return nil, cli.VerbErrorf(verb, "option \"%s\" not recognized", opt)
|
|
}
|
|
}
|
|
|
|
if fillDownFieldNames == nil && !doAll {
|
|
return nil, cli.VerbErrorf(verb, "-f field names or --all required")
|
|
}
|
|
|
|
*pargi = argi
|
|
if !doConstruct { // All transformers must do this for main command-line parsing
|
|
return nil, nil
|
|
}
|
|
|
|
transformer, err := NewTransformerFillDown(
|
|
fillDownFieldNames,
|
|
doAll,
|
|
onlyIfAbsent,
|
|
)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
return transformer, nil
|
|
}
|
|
|
|
type TransformerFillDown struct {
|
|
// input
|
|
fillDownFieldNames []string
|
|
onlyIfAbsent bool
|
|
|
|
// state
|
|
lastNonNullValues map[string]*mlrval.Mlrval
|
|
|
|
recordTransformerFunc RecordTransformerFunc
|
|
}
|
|
|
|
func NewTransformerFillDown(
|
|
fillDownFieldNames []string,
|
|
doAll bool,
|
|
onlyIfAbsent bool,
|
|
) (*TransformerFillDown, error) {
|
|
tr := &TransformerFillDown{
|
|
fillDownFieldNames: fillDownFieldNames,
|
|
onlyIfAbsent: onlyIfAbsent,
|
|
lastNonNullValues: make(map[string]*mlrval.Mlrval),
|
|
}
|
|
|
|
if doAll {
|
|
tr.recordTransformerFunc = tr.transformAll
|
|
} else {
|
|
tr.recordTransformerFunc = tr.transformSpecified
|
|
}
|
|
|
|
return tr, nil
|
|
}
|
|
|
|
func (tr *TransformerFillDown) Transform(
|
|
inrecAndContext *types.RecordAndContext,
|
|
outputRecordsAndContexts *[]*types.RecordAndContext, // list of *types.RecordAndContext
|
|
inputDownstreamDoneChannel <-chan bool,
|
|
outputDownstreamDoneChannel chan<- bool,
|
|
) {
|
|
HandleDefaultDownstreamDone(inputDownstreamDoneChannel, outputDownstreamDoneChannel)
|
|
tr.recordTransformerFunc(inrecAndContext, outputRecordsAndContexts, inputDownstreamDoneChannel, outputDownstreamDoneChannel)
|
|
}
|
|
|
|
func (tr *TransformerFillDown) transformSpecified(
|
|
inrecAndContext *types.RecordAndContext,
|
|
outputRecordsAndContexts *[]*types.RecordAndContext, // list of *types.RecordAndContext
|
|
inputDownstreamDoneChannel <-chan bool,
|
|
outputDownstreamDoneChannel chan<- bool,
|
|
) {
|
|
if !inrecAndContext.EndOfStream {
|
|
inrec := inrecAndContext.Record
|
|
|
|
for _, fillDownFieldName := range tr.fillDownFieldNames {
|
|
present := false
|
|
value := inrec.Get(fillDownFieldName)
|
|
if tr.onlyIfAbsent {
|
|
present = value != nil
|
|
} else {
|
|
present = value != nil && !value.IsVoid()
|
|
}
|
|
|
|
if present {
|
|
// Remember it for a subsequent record lacking this field
|
|
tr.lastNonNullValues[fillDownFieldName] = value.Copy()
|
|
} else {
|
|
// Reuse previously seen value, if any
|
|
prev, ok := tr.lastNonNullValues[fillDownFieldName]
|
|
if ok {
|
|
inrec.PutCopy(fillDownFieldName, prev)
|
|
}
|
|
}
|
|
}
|
|
|
|
*outputRecordsAndContexts = append(*outputRecordsAndContexts, inrecAndContext)
|
|
|
|
} else {
|
|
*outputRecordsAndContexts = append(*outputRecordsAndContexts, inrecAndContext) // end-of-stream marker
|
|
}
|
|
}
|
|
|
|
func (tr *TransformerFillDown) transformAll(
|
|
inrecAndContext *types.RecordAndContext,
|
|
outputRecordsAndContexts *[]*types.RecordAndContext, // list of *types.RecordAndContext
|
|
inputDownstreamDoneChannel <-chan bool,
|
|
outputDownstreamDoneChannel chan<- bool,
|
|
) {
|
|
if !inrecAndContext.EndOfStream {
|
|
inrec := inrecAndContext.Record
|
|
|
|
for pe := inrec.Head; pe != nil; pe = pe.Next {
|
|
fillDownFieldName := pe.Key
|
|
present := false
|
|
value := inrec.Get(fillDownFieldName)
|
|
if tr.onlyIfAbsent {
|
|
present = value != nil
|
|
} else {
|
|
present = value != nil && !value.IsVoid()
|
|
}
|
|
|
|
if present {
|
|
// Remember it for a subsequent record lacking this field
|
|
tr.lastNonNullValues[fillDownFieldName] = value.Copy()
|
|
} else {
|
|
// Reuse previously seen value, if any
|
|
prev, ok := tr.lastNonNullValues[fillDownFieldName]
|
|
if ok {
|
|
inrec.PutCopy(fillDownFieldName, prev)
|
|
}
|
|
}
|
|
}
|
|
|
|
*outputRecordsAndContexts = append(*outputRecordsAndContexts, inrecAndContext)
|
|
|
|
} else {
|
|
*outputRecordsAndContexts = append(*outputRecordsAndContexts, inrecAndContext) // end-of-stream marker
|
|
}
|
|
}
|