mirror of
https://github.com/johnkerl/miller.git
synced 2026-07-17 16:38:54 +00:00
* refine the plan
* Fix all staticcheck lint findings (uncapped)
golangci-lint's default max-same-issues=3 was hiding most of the backlog:
the true pre-fix count was 69 staticcheck findings, not 34. This fixes all
of them, driving staticcheck to zero:
- ST1023/QF1011 (37): omit explicit types inferred from the RHS
- S1009/S1031 (15): drop redundant nil checks before len()/range
- SA9003 (9): remove comment-only empty branches, keeping the comments
- QF1007 (3): merge conditional assignment into declaration
- QF1006 (3): lift break conditions into loop conditions
- QF1001 (3): apply De Morgan's law / name the negated predicate
Also updates plans/lintfixes.md with the cap discovery and the corrected
errcheck picture (1202 uncapped, ~949 of them fmt.Fprint*).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* Drive errcheck to zero: config for bulk categories, propagate real errors
Adds .golangci.yml with errcheck exclude-functions for fmt.Fprint* (usage
printers), (*bufio.Writer).Write/WriteString (sticky errors, surfaced at the
now-checked final Flush), and (*strings.Builder).WriteString; pins
max-issues-per-linter/max-same-issues to 0 so CI reports true counts.
Real error paths now propagate instead of being dropped:
- Finalize{Reader,Writer}Options in join/put/filter/split/tee and the
repl/script entry points: 'mlr join -i badformat' now errors instead of
silently using wrong separators
- final output-stream Flush in pkg/stream: write failure no longer exits 0
- DSL emit/print/dump redirect writes, matching their sibling branches
- CSV writer WriteCSVRecordMaybeColorized, close-time Flush in file output
handlers, ENV[...] Setenv, REPL record-write and redirect-close errors
- termcvt write-side Close before rename (had "TODO: check return status")
The rest are deliberate ignores, marked with _ = and a comment where the
reason isn't obvious: unset-of-missing-path no-ops, read-side closes,
mid-stream FlushOnEveryRecord, init-time strftime registrations, in-memory
usage-capture pipes, and regtest-harness env/temp-file teardown.
golangci-lint now reports 0 issues on ./cmd/mlr ./pkg/... with all caps off.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
90 lines
2.2 KiB
Go
90 lines
2.2 KiB
Go
// Routines for loading strings from files. Nominally for the put/filter verbs
|
|
// to load DSL strings from .mlr files.
|
|
|
|
package lib
|
|
|
|
import (
|
|
"os"
|
|
"strings"
|
|
|
|
csv "github.com/johnkerl/miller/v6/pkg/go-csv"
|
|
)
|
|
|
|
// LoadStringsFromFileOrDir calls LoadStringFromFile if path exists and is a
|
|
// file, or LoadStringsFromDir if path exists and is a directory. In the
|
|
// former case the extension is ignored; in the latter case it's used as a
|
|
// filter on the directory entries.
|
|
func LoadStringsFromFileOrDir(path string, extension string) ([]string, error) {
|
|
fileInfo, err := os.Stat(path)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
if fileInfo.IsDir() {
|
|
return LoadStringsFromDir(path, extension)
|
|
}
|
|
dslString, err := LoadStringFromFile(path)
|
|
if err != nil {
|
|
return nil, err
|
|
} else {
|
|
return []string{dslString}, nil
|
|
}
|
|
}
|
|
|
|
// LoadStringFromFile is just a wrapper around os.ReadFile,
|
|
// with a cast from []byte to string.
|
|
func LoadStringFromFile(filename string) (string, error) {
|
|
data, err := os.ReadFile(filename)
|
|
if err != nil {
|
|
return "", err
|
|
}
|
|
return string(data), nil
|
|
}
|
|
|
|
// LoadStringsFromDir loads all file contents for files in the given directory
|
|
// having the given extension. E.g. LoadStringsFromDir("/u/myfiles", ".mlr")
|
|
// will load /u/myfiles/foo.mlr and /u/myfiles/bar.mlr but will skip over
|
|
// /u/myfiles/data.csv and /u/myfiles/todo.txt.
|
|
func LoadStringsFromDir(dirname string, extension string) ([]string, error) {
|
|
dslStrings := []string{}
|
|
|
|
f, err := os.Open(dirname)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
defer func() { _ = f.Close() }()
|
|
|
|
names, err := f.Readdirnames(-1)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
for _, name := range names {
|
|
if !strings.HasSuffix(name, extension) {
|
|
continue
|
|
}
|
|
|
|
path := dirname + "/" + name
|
|
dslString, err := LoadStringFromFile(path)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
dslStrings = append(dslStrings, dslString)
|
|
}
|
|
|
|
return dslStrings, nil
|
|
}
|
|
|
|
func ReadCSVHeader(filename string) ([]string, error) {
|
|
handle, err := os.Open(filename)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
defer func() { _ = handle.Close() }()
|
|
csvReader := csv.NewReader(handle)
|
|
header, err := csvReader.Read()
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
return header, nil
|
|
}
|