miller/pkg/auxents/termcvt.go
John Kerl 91eaff1341
Lint round 5+6: staticcheck and errcheck to zero (#2130)
* refine the plan

* Fix all staticcheck lint findings (uncapped)

golangci-lint's default max-same-issues=3 was hiding most of the backlog:
the true pre-fix count was 69 staticcheck findings, not 34. This fixes all
of them, driving staticcheck to zero:

- ST1023/QF1011 (37): omit explicit types inferred from the RHS
- S1009/S1031 (15): drop redundant nil checks before len()/range
- SA9003 (9): remove comment-only empty branches, keeping the comments
- QF1007 (3): merge conditional assignment into declaration
- QF1006 (3): lift break conditions into loop conditions
- QF1001 (3): apply De Morgan's law / name the negated predicate

Also updates plans/lintfixes.md with the cap discovery and the corrected
errcheck picture (1202 uncapped, ~949 of them fmt.Fprint*).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* Drive errcheck to zero: config for bulk categories, propagate real errors

Adds .golangci.yml with errcheck exclude-functions for fmt.Fprint* (usage
printers), (*bufio.Writer).Write/WriteString (sticky errors, surfaced at the
now-checked final Flush), and (*strings.Builder).WriteString; pins
max-issues-per-linter/max-same-issues to 0 so CI reports true counts.

Real error paths now propagate instead of being dropped:
- Finalize{Reader,Writer}Options in join/put/filter/split/tee and the
  repl/script entry points: 'mlr join -i badformat' now errors instead of
  silently using wrong separators
- final output-stream Flush in pkg/stream: write failure no longer exits 0
- DSL emit/print/dump redirect writes, matching their sibling branches
- CSV writer WriteCSVRecordMaybeColorized, close-time Flush in file output
  handlers, ENV[...] Setenv, REPL record-write and redirect-close errors
- termcvt write-side Close before rename (had "TODO: check return status")

The rest are deliberate ignores, marked with _ = and a comment where the
reason isn't obvious: unset-of-missing-path no-ops, read-side closes,
mid-stream FlushOnEveryRecord, init-time strftime registrations, in-memory
usage-capture pipes, and regtest-harness env/temp-file teardown.

golangci-lint now reports 0 issues on ./cmd/mlr ./pkg/... with all caps off.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
2026-07-03 11:42:08 -04:00

154 lines
3.6 KiB
Go

package auxents
import (
"bufio"
"fmt"
"io"
"os"
"strings"
)
func termcvtUsage(verbName string, o *os.File, exitCode int) {
fmt.Fprintf(o, "Usage: mlr %s [option] {zero or more file names}\n", verbName)
fmt.Fprintf(o, "Option (exactly one is required):\n")
fmt.Fprintf(o, "--cr2crlf\n")
fmt.Fprintf(o, "--lf2crlf\n")
fmt.Fprintf(o, "--crlf2cr\n")
fmt.Fprintf(o, "--crlf2lf\n")
fmt.Fprintf(o, "--cr2lf\n")
fmt.Fprintf(o, "--lf2cr\n")
fmt.Fprintf(o, "-I in-place processing (default is to write to stdout)\n")
fmt.Fprintf(o, "-h or --help: print this message\n")
fmt.Fprintf(o, "Zero file names means read from standard input.\n")
fmt.Fprintf(o, "Output is always to standard output; files are not written in-place.\n")
os.Exit(exitCode)
}
func termcvtMain(args []string) int {
inputTerminator := "\n"
outputTerminator := "\n"
doInPlace := false
// 'mlr' and 'termcvt' are already argv[0] and argv[1].
verb := args[1]
args = args[2:]
if len(args) < 1 {
termcvtUsage(verb, os.Stderr, 1)
}
for len(args) >= 1 {
opt := args[0]
if opt[0] != '-' {
break
}
args = args[1:]
switch opt {
case "-h", "--help":
termcvtUsage(verb, os.Stdout, 0)
case "-I":
doInPlace = true
case "--cr2crlf":
inputTerminator = "\r"
outputTerminator = "\r\n"
case "--lf2crlf":
inputTerminator = "\n"
outputTerminator = "\r\n"
case "--crlf2cr":
inputTerminator = "\r\n"
outputTerminator = "\r"
case "--lf2cr":
inputTerminator = "\n"
outputTerminator = "\r"
case "--crlf2lf":
inputTerminator = "\r\n"
outputTerminator = "\n"
case "--cr2lf":
inputTerminator = "\r"
outputTerminator = "\n"
default:
termcvtUsage(verb, os.Stderr, 1)
}
}
if len(args) == 0 {
termcvtFile(os.Stdin, os.Stdout, inputTerminator, outputTerminator)
} else if doInPlace {
for _, filename := range args {
// TODO: make re-entrant via long-random suffix
suffix := "-termcvt-temp"
tempname := filename + suffix
istream, err := os.Open(filename)
if err != nil {
// TODO: "mlr"
fmt.Fprintf(os.Stderr, "mlr termcvt: %v\n", err)
os.Exit(1)
}
ostream, err := os.Open(tempname)
if err != nil {
// TODO: "mlr"
fmt.Fprintf(os.Stderr, "mlr termcvt: %v\n", err)
os.Exit(1)
}
termcvtFile(istream, ostream, inputTerminator, outputTerminator)
_ = istream.Close()
if err := ostream.Close(); err != nil {
fmt.Fprintf(os.Stderr, "mlr termcvt: %v\n", err)
os.Exit(1)
}
err = os.Rename(tempname, filename)
if err != nil {
// TODO: "mlr"
fmt.Fprintf(os.Stderr, "mlr termcvt: %v\n", err)
os.Exit(1)
}
}
} else {
for _, filename := range args {
istream, err := os.Open(filename)
if err != nil {
// TODO: "mlr"
fmt.Fprintf(os.Stderr, "mlr termcvt: %v\n", err)
os.Exit(1)
}
termcvtFile(istream, os.Stdout, inputTerminator, outputTerminator)
_ = istream.Close()
}
}
return 0
}
func termcvtFile(istream *os.File, ostream *os.File, inputTerminator string, outputTerminator string) {
lineReader := bufio.NewReader(istream)
inputTerminatorBytes := []byte(inputTerminator[len(inputTerminator)-1:])[0] // bufio.Reader.ReadString takes char not string delimiter :(
for {
line, err := lineReader.ReadString(inputTerminatorBytes)
if err == io.EOF {
break
}
if err != nil {
// TODO: "mlr"
fmt.Fprintf(os.Stderr, "mlr termcvt: %v\n", err)
os.Exit(1)
}
// This is how to do a chomp:
line = strings.TrimRight(line, inputTerminator)
if _, err := ostream.Write([]byte(line + outputTerminator)); err != nil {
fmt.Fprintf(os.Stderr, "mlr termcvt: %v\n", err)
os.Exit(1)
}
}
}