feature(cloudcmd) deprecate localStorage

This commit is contained in:
coderaiser 2018-05-14 15:10:46 +03:00
parent d6c3a240b5
commit e77e2dbcce
2 changed files with 34 additions and 4 deletions

View file

@ -45,14 +45,17 @@ const root = () => config('root');
const notEmpty = (a) => a;
const clean = (a) => a.filter(notEmpty);
const noop = () => {};
const deprecateOnePanelMode = (value) => {
const noop = () => {};
util.deprecate(noop, 'onePanelMode is deprecated, use oneFilePanel instead', 'DP0001')();
config('oneFilePanel', value);
};
const deprecateLocalStorage = (value) => {
util.deprecate(noop, 'localStorage is deprecated', 'DP0002')();
config('localStorage', value);
};
module.exports = (params) => {
const p = params || {};
const options = p.config || {};
@ -66,7 +69,9 @@ module.exports = (params) => {
keys.forEach((name) => {
const value = options[name];
if (name === 'onePanelMode')
if (name === 'localStorage')
deprecateLocalStorage(value);
else if (name === 'onePanelMode')
deprecateOnePanelMode();
else if (name === 'oneFilePanel')
config('onePanelMode', value);

View file

@ -222,6 +222,31 @@ test('cloudcmd: getIndexPath: development', (t) => {
t.end();
});
test('cloudcmd: deprecated: localStorage', (t) => {
const config = {
localStorage: false
};
const {
deprecate: originalDeprecate
} = util;
const deprecate = sinon
.stub()
.returns(noop);
util.deprecate = deprecate;
cloudcmd({
config
});
util.deprecate = originalDeprecate;
t.ok(deprecate.called, 'should call deprecate');
t.end();
});
test('cloudcmd: deprecated: one panel mode', (t) => {
const config = {
onePanelMode: true