diff --git a/server/cloudcmd.js b/server/cloudcmd.js index 7e82132e..6f702122 100644 --- a/server/cloudcmd.js +++ b/server/cloudcmd.js @@ -45,14 +45,17 @@ const root = () => config('root'); const notEmpty = (a) => a; const clean = (a) => a.filter(notEmpty); +const noop = () => {}; const deprecateOnePanelMode = (value) => { - const noop = () => {}; - util.deprecate(noop, 'onePanelMode is deprecated, use oneFilePanel instead', 'DP0001')(); - config('oneFilePanel', value); }; +const deprecateLocalStorage = (value) => { + util.deprecate(noop, 'localStorage is deprecated', 'DP0002')(); + config('localStorage', value); +}; + module.exports = (params) => { const p = params || {}; const options = p.config || {}; @@ -66,7 +69,9 @@ module.exports = (params) => { keys.forEach((name) => { const value = options[name]; - if (name === 'onePanelMode') + if (name === 'localStorage') + deprecateLocalStorage(value); + else if (name === 'onePanelMode') deprecateOnePanelMode(); else if (name === 'oneFilePanel') config('onePanelMode', value); diff --git a/test/server/cloudcmd.js b/test/server/cloudcmd.js index 79c83ef3..537ac7f4 100644 --- a/test/server/cloudcmd.js +++ b/test/server/cloudcmd.js @@ -222,6 +222,31 @@ test('cloudcmd: getIndexPath: development', (t) => { t.end(); }); +test('cloudcmd: deprecated: localStorage', (t) => { + const config = { + localStorage: false + }; + + const { + deprecate: originalDeprecate + } = util; + + const deprecate = sinon + .stub() + .returns(noop); + + util.deprecate = deprecate; + + cloudcmd({ + config + }); + + util.deprecate = originalDeprecate; + + t.ok(deprecate.called, 'should call deprecate'); + t.end(); +}); + test('cloudcmd: deprecated: one panel mode', (t) => { const config = { onePanelMode: true