Commit graph

1307 commits

Author SHA1 Message Date
Jordan Eldredge
e79520dbdd Don't allow global access to all of window
We had a bug where `stop()` was undefined but it fell back to the function on window which was inplicitly in the global scope.

This should reduce that kind of thing.
2019-11-30 13:42:53 -08:00
Jordan Eldredge
0472033fba Make Desktop a functional component with hooks 2019-11-30 13:42:53 -08:00
Jordan Eldredge
e3b3eab63e Make AlbumsTable a functional component 2019-11-30 13:42:53 -08:00
Jordan Eldredge
ab6d1ff3bb Fix the stop button
Aparently window.stop() is a thing, and ESLint/TypeScript let me do this. Sigh.

A potential fix: https://github.com/facebook/create-react-app/pull/1840
2019-11-30 13:42:53 -08:00
Jordan Eldredge
567ad29a76 Use react-redux hooks for MainWindow/index
This is the last main window component still using the HOC!
2019-11-30 13:42:53 -08:00
Jordan Eldredge
c1cfd98b21 Remove unused types 2019-11-30 13:42:53 -08:00
Jordan Eldredge
cc578845a6 Use react-redux for Position and Repeat 2019-11-30 13:42:53 -08:00
Jordan Eldredge
9b9421ae54 Use react-redux hooks in Shade 2019-11-30 13:42:53 -08:00
Jordan Eldredge
80c4e2fa10 Use react-redux hooks in Shuffle 2019-11-30 13:42:53 -08:00
Jordan Eldredge
81b5bcfdfd Use react-redux hooks in Time 2019-11-30 13:42:53 -08:00
Jordan Eldredge
f51e51eea2 Use hooks for main context window 2019-11-30 13:42:53 -08:00
Jordan Eldredge
f4230553a8 Type PlaylistTogggleButton 2019-11-30 13:42:53 -08:00
Jordan Eldredge
e7c474e7f6 Inline style 2019-11-30 13:42:53 -08:00
Jordan Eldredge
e345d07e41 Use react-redux hooks for Marquee 2019-11-30 13:42:53 -08:00
Jordan Eldredge
822391c401 Clean up unused type 2019-11-30 13:42:53 -08:00
Jordan Eldredge
f32de1e653 Use react-redux hooks in a few more places 2019-11-30 13:42:53 -08:00
Jordan Eldredge
d6454510a9 Refactor Marquee to use hooks
This actually removes a bunch of edgecases/race conditions
2019-11-30 13:42:53 -08:00
Jordan Eldredge
73b025bf12 Ensure ESLint is running on Travis
It used to run as part of Jest. When I moved it back to its own thing,
I guess I forgot to add it back to Travis.
2019-11-30 13:42:53 -08:00
Jordan Eldredge
443392dadb Memoize getting track display name 2019-11-30 13:42:53 -08:00
Jordan Eldredge
f39449b46c Refactor to functional component, and remove unused dispatch prop 2019-11-30 13:42:53 -08:00
Jordan Eldredge
d8b33e4795 Start using react redux hooks (#845)
* Upgrade react-redux

* Upgrade react-redux types

* Start adopting react-redux hooks
2019-11-30 13:42:53 -08:00
Jordan Eldredge
a98e63cbc4 Fix incorrect case of file 2019-11-30 13:42:53 -08:00
jberg
35c9167f2d don't cycle presets when media is not playing (#799) 2019-11-30 13:42:53 -08:00
Jordan Eldredge
59e41c87d6 Revert "POC: Try adding rexux-observable"
This reverts commit 58fd75c8a1.
2019-11-30 13:42:53 -08:00
Jordan Eldredge
577b5e3c17 Handle = as comment separator in .ini files 2019-11-30 13:42:53 -08:00
Jordan Eldredge
765825ab22 POC: Try adding rexux-observable
I don't know how we'll feasibly solve the multide of potential race conditons and async clean up memory leaks without something like rxjs. So, this is a trial to see the following:

1. How much does it increase bundle size?
2. How effective is typechecking?
3. Does it solve some of the difficult cancelation issues we have?
2019-11-30 13:42:53 -08:00
Jordan Eldredge
404a502d86 update snapshots 2019-11-30 13:42:53 -08:00
Isaiah Odhner
05741eccfd Fix target="_blank" (#794)
It's tricky because "blank" (without an underscore) will still open a new tab, but it's actually being interpreted as a browsing context name, and so clicking it a second time will replace the previously opened tab (even if navigated away).
2019-06-06 15:03:49 -07:00
Jordan Eldredge
3ed14877e1 Avoid warnings due to Webpack issue #7378 2019-06-05 16:28:46 -07:00
Jordan Eldredge
3458c87472 Fix 'New List' behavior
Fixes #790
2019-05-28 21:55:27 -07:00
Jordan Eldredge
29b4e0db71
Add a method to set the skin (#787)
Fixes #733
2019-05-21 07:58:18 -07:00
Jordan Eldredge
b3a17c8f99 Release 1.4.0 2019-05-14 08:04:54 -07:00
Jordan Eldredge
6994362e58 createPattern can take an image directly
I can't belive I was doing this whole extra dance
2019-05-10 08:24:09 -07:00
Jordan Eldredge
6799e2fa5a
Try running screenshot tests on Travis (#782)
* Try running screenshot tests on Travis

* Standardize domain in integration tests

* Allow images to not match that well

* Turn back on all other tests
2019-05-09 17:55:53 -07:00
Jordan Eldredge
0c94263f0f Improve integration test timeouts 2019-05-09 17:15:22 -07:00
Jordan Eldredge
53218aba6e Update integration tests and snapshots 2019-05-09 16:23:16 -07:00
Jordan Eldredge
348c000a49 Enable StricMode for subtrees that are compatible 2019-05-09 09:31:31 -07:00
Jordan Eldredge
fe00036cbf Use common utility function to get img from url 2019-05-09 08:02:27 -07:00
Jordan Eldredge
2dca07ff0a Make a best effort to prewarm the images needed for the eq graph 2019-05-09 07:59:54 -07:00
Jordan Eldredge
1a45099045 Use MutationObserver to detect focused decedents leaving the DOM 2019-05-07 19:35:17 -07:00
Jordan Eldredge
c56bf0a964 Use React's blur event to detect with Webamp itself loses focus 2019-05-07 17:08:08 -07:00
Jordan Eldredge
bd3f986ade Only clear focus is the focus is leaving the app 2019-05-06 22:22:32 -07:00
Jordan Eldredge
bd1999778d Fix bug with ref
When using a ref in an effect, you need to use a state ref, otherwise the binding happens too early.
2019-05-06 22:22:13 -07:00
Jordan Eldredge
e5f6edf602 Add onMouseDown handlers to snapshots 2019-05-02 19:56:25 -07:00
Jordan Eldredge
5ee1a4f7b0 Order windows based upon which one was last clicked 2019-05-02 17:46:02 -07:00
Jordan Eldredge
3aa25f0b55 Focus target on click
I'm not sure why onFoucs+tabIndex does not do this
2019-05-02 17:45:07 -07:00
Jordan Eldredge
2569e7fb95 Remove logic that resets position on track load
I think this dates from back when we only had one track at a time, or something.

Fixes #775
2019-05-02 16:58:05 -07:00
Jordan Eldredge
f8167dd322 Autoplay tracks that are dropped on the main window 2019-05-02 16:58:05 -07:00
Jordan Eldredge
8a4a594dd0 Change nesting to preserve playlist styling
The `#playlist-window` div is a flex container so it needs to be the direct parent.
2019-05-02 16:58:01 -07:00
Jordan Eldredge
0f97529a39 Update snapshot to reflect new version of rc-slider 2019-05-02 16:32:29 -07:00