Commit graph

1313 commits

Author SHA1 Message Date
Jordan Eldredge
e7dc2e9ba3 Fix snapshots to work with new version of rc-slider 2019-09-10 08:05:42 -07:00
Jordan Eldredge
5bcf67f975 Upgrade rc-slider and lift React.StrictMode
rc-slider was preventing us from enabling this more broadly. With https://github.com/react-component/slider/pull/591 merged and released, we can make more of the app strict
2019-09-06 20:58:40 -07:00
Jordan Eldredge
19c0762853 Refactor portals to use hooks rather than deprecated lifecycle methods 2019-09-06 20:58:40 -07:00
Jordan Eldredge
83d9443328 Fix lints 2019-08-24 22:30:48 -07:00
Jordan Eldredge
84651f4567 Fix typing for Desktop 2019-08-20 09:19:19 -07:00
Jordan Eldredge
983b574da2 Actually use useDispatch 2019-08-20 09:10:12 -07:00
Jordan Eldredge
0b3d28767f Don't allow global access to all of window
We had a bug where `stop()` was undefined but it fell back to the function on window which was inplicitly in the global scope.

This should reduce that kind of thing.
2019-08-20 07:43:23 -07:00
Jordan Eldredge
6a53539776 Make Desktop a functional component with hooks 2019-08-20 07:43:23 -07:00
Jordan Eldredge
2a5798012f Make AlbumsTable a functional component 2019-08-20 07:43:23 -07:00
Jordan Eldredge
5407426325 Fix the stop button
Aparently window.stop() is a thing, and ESLint/TypeScript let me do this. Sigh.

A potential fix: https://github.com/facebook/create-react-app/pull/1840
2019-08-20 07:43:23 -07:00
Jordan Eldredge
7a1191c1e5 Use react-redux hooks for MainWindow/index
This is the last main window component still using the HOC!
2019-08-20 07:43:23 -07:00
Jordan Eldredge
54eba236ef Remove unused types 2019-08-20 07:43:23 -07:00
Jordan Eldredge
7212b9e895 Use react-redux for Position and Repeat 2019-08-20 07:43:23 -07:00
Jordan Eldredge
cc0e1aa5ee Use react-redux hooks in Shade 2019-08-20 07:43:23 -07:00
Jordan Eldredge
576689642a Use react-redux hooks in Shuffle 2019-08-20 07:43:23 -07:00
Jordan Eldredge
2e95a04ec9 Use react-redux hooks in Time 2019-08-20 07:43:23 -07:00
Jordan Eldredge
357c139af5 Use hooks for main context window 2019-08-20 07:43:23 -07:00
Jordan Eldredge
a0c01272bd Type PlaylistTogggleButton 2019-08-20 07:43:23 -07:00
Jordan Eldredge
3cb7de0ba0 Inline style 2019-08-20 07:43:23 -07:00
Jordan Eldredge
2c7c449b1a Use react-redux hooks for Marquee 2019-08-20 07:43:23 -07:00
Jordan Eldredge
eaf9e8e27a Clean up unused type 2019-08-20 07:43:23 -07:00
Jordan Eldredge
6f54b5aeab Use react-redux hooks in a few more places 2019-08-20 07:43:23 -07:00
Jordan Eldredge
48bd60bff7 Refactor Marquee to use hooks
This actually removes a bunch of edgecases/race conditions
2019-08-20 07:43:23 -07:00
Jordan Eldredge
0be6ff9ede Ensure ESLint is running on Travis
It used to run as part of Jest. When I moved it back to its own thing,
I guess I forgot to add it back to Travis.
2019-08-18 14:00:06 -07:00
Jordan Eldredge
c23b2b4171 Memoize getting track display name 2019-08-13 06:36:51 -07:00
Jordan Eldredge
b3824d7ebd Refactor to functional component, and remove unused dispatch prop 2019-08-13 06:36:51 -07:00
Jordan Eldredge
da4d7f83ad
Start using react redux hooks (#845)
* Upgrade react-redux

* Upgrade react-redux types

* Start adopting react-redux hooks
2019-08-09 10:10:20 -07:00
Jordan Eldredge
c76a20234c Fix incorrect case of file 2019-06-26 18:47:39 -07:00
jberg
43fd626dbc don't cycle presets when media is not playing (#799) 2019-06-26 14:55:52 -07:00
Jordan Eldredge
76af4b6436 Revert "POC: Try adding rexux-observable"
This reverts commit 58fd75c8a1.
2019-06-14 22:38:10 -07:00
Jordan Eldredge
b74febb261 Handle = as comment separator in .ini files 2019-06-14 22:29:48 -07:00
Jordan Eldredge
58fd75c8a1 POC: Try adding rexux-observable
I don't know how we'll feasibly solve the multide of potential race conditons and async clean up memory leaks without something like rxjs. So, this is a trial to see the following:

1. How much does it increase bundle size?
2. How effective is typechecking?
3. Does it solve some of the difficult cancelation issues we have?
2019-06-13 19:21:41 -07:00
Jordan Eldredge
4deaa41941 update snapshots 2019-06-09 13:28:19 -07:00
Isaiah Odhner
05741eccfd Fix target="_blank" (#794)
It's tricky because "blank" (without an underscore) will still open a new tab, but it's actually being interpreted as a browsing context name, and so clicking it a second time will replace the previously opened tab (even if navigated away).
2019-06-06 15:03:49 -07:00
Jordan Eldredge
3ed14877e1 Avoid warnings due to Webpack issue #7378 2019-06-05 16:28:46 -07:00
Jordan Eldredge
3458c87472 Fix 'New List' behavior
Fixes #790
2019-05-28 21:55:27 -07:00
Jordan Eldredge
29b4e0db71
Add a method to set the skin (#787)
Fixes #733
2019-05-21 07:58:18 -07:00
Jordan Eldredge
b3a17c8f99 Release 1.4.0 2019-05-14 08:04:54 -07:00
Jordan Eldredge
6994362e58 createPattern can take an image directly
I can't belive I was doing this whole extra dance
2019-05-10 08:24:09 -07:00
Jordan Eldredge
6799e2fa5a
Try running screenshot tests on Travis (#782)
* Try running screenshot tests on Travis

* Standardize domain in integration tests

* Allow images to not match that well

* Turn back on all other tests
2019-05-09 17:55:53 -07:00
Jordan Eldredge
0c94263f0f Improve integration test timeouts 2019-05-09 17:15:22 -07:00
Jordan Eldredge
53218aba6e Update integration tests and snapshots 2019-05-09 16:23:16 -07:00
Jordan Eldredge
348c000a49 Enable StricMode for subtrees that are compatible 2019-05-09 09:31:31 -07:00
Jordan Eldredge
fe00036cbf Use common utility function to get img from url 2019-05-09 08:02:27 -07:00
Jordan Eldredge
2dca07ff0a Make a best effort to prewarm the images needed for the eq graph 2019-05-09 07:59:54 -07:00
Jordan Eldredge
1a45099045 Use MutationObserver to detect focused decedents leaving the DOM 2019-05-07 19:35:17 -07:00
Jordan Eldredge
c56bf0a964 Use React's blur event to detect with Webamp itself loses focus 2019-05-07 17:08:08 -07:00
Jordan Eldredge
bd3f986ade Only clear focus is the focus is leaving the app 2019-05-06 22:22:32 -07:00
Jordan Eldredge
bd1999778d Fix bug with ref
When using a ref in an effect, you need to use a state ref, otherwise the binding happens too early.
2019-05-06 22:22:13 -07:00
Jordan Eldredge
e5f6edf602 Add onMouseDown handlers to snapshots 2019-05-02 19:56:25 -07:00