From ebd72e13f40d3dc3ec386e859248974f6871b97c Mon Sep 17 00:00:00 2001 From: Jordan Eldredge Date: Tue, 19 Mar 2019 06:55:23 -0700 Subject: [PATCH] Make some existing errors warnings We are enabling eslint for TypeScript files, which have not historically had this type of check. Rather than trying to fix all these issues up front, we'll convert them to warnings and fix them in the future. Hopefully we can reenable them soon. --- .eslintrc | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.eslintrc b/.eslintrc index 92be38b3..354fee0a 100644 --- a/.eslintrc +++ b/.eslintrc @@ -101,7 +101,7 @@ "no-octal-escape": "error", "no-proto": "error", "no-redeclare": "error", - "no-shadow": "error", + "no-shadow": "warn", "no-spaced-func": "error", "no-this-before-super": "error", "no-throw-literal": "error", @@ -112,7 +112,7 @@ "no-unreachable": "error", "no-unused-expressions": "error", "@typescript-eslint/no-unused-vars": [ - "error", + "warn", { "ignoreRestSiblings": true } ], "no-use-before-define": ["error", "nofunc"], @@ -129,7 +129,7 @@ "react/jsx-boolean-value": "error", "react/jsx-uses-react": "error", "react/jsx-uses-vars": "error", - "react/prefer-stateless-function": "error", + "react/prefer-stateless-function": "warn", "react/prefer-es6-class": "error", "react/jsx-pascal-case": "error", "react/require-render-return": "error", @@ -147,7 +147,7 @@ "import/no-extraneous-dependencies": "error", "import/no-named-as-default-member": "error", "import/no-unresolved": "error", - "import/order": "error", + "import/order": "warn", "no-constructor-bind/no-constructor-bind": "error" } }