From cb2254bdb79b7cde1259122d0d9fd334cfed193a Mon Sep 17 00:00:00 2001 From: Jordan Eldredge Date: Sat, 2 Mar 2024 12:24:41 -0800 Subject: [PATCH] Fix uncovered type errors --- packages/webamp/demo/js/mediaSession.ts | 7 +++---- packages/webamp/js/marqueeUtils.tsx | 4 ++-- 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/packages/webamp/demo/js/mediaSession.ts b/packages/webamp/demo/js/mediaSession.ts index f18d2840..2cb135de 100644 --- a/packages/webamp/demo/js/mediaSession.ts +++ b/packages/webamp/demo/js/mediaSession.ts @@ -10,11 +10,10 @@ export default function enableMediaSession(webamp: WebampLazy) { const { metaData: { title, artist, album, albumArtUrl }, } = track; - // @ts-ignore TypeScript does not know about the Media Session API: https://github.com/Microsoft/TypeScript/issues/19473 navigator.mediaSession.metadata = new MediaMetadata({ - title, - artist, - album, + title: title ?? undefined, + artist: artist ?? undefined, + album: album ?? undefined, artwork: albumArtUrl ? [ { diff --git a/packages/webamp/js/marqueeUtils.tsx b/packages/webamp/js/marqueeUtils.tsx index a2cbebe3..446a4d7e 100644 --- a/packages/webamp/js/marqueeUtils.tsx +++ b/packages/webamp/js/marqueeUtils.tsx @@ -31,7 +31,7 @@ const formatHz = (hz: number): string => hz < 1000 ? `${hz}HZ` : `${hz / 1000}KHZ`; // Format a number as a string, ensuring it has a + or - sign -const ensureSign = (num: number | string): string => +const ensureSign = (num: number): string => num > 0 ? `+${num}` : num.toString(); // Round to 1 and exactly 1 decimal point @@ -41,5 +41,5 @@ const roundToTenths = (num: number): string => export const getEqText = (band: Slider, level: number): string => { const db = roundToTenths(((level - 50) / 50) * 12); const label = band === "preamp" ? "Preamp" : formatHz(band); - return `EQ: ${label} ${ensureSign(db)} DB`; + return `EQ: ${label} ${ensureSign(Number(db))} DB`; };