From c75214dcd7475b27f24c159cda26117a143ff740 Mon Sep 17 00:00:00 2001 From: Jordan Eldredge Date: Thu, 2 May 2019 07:23:41 -0700 Subject: [PATCH] Improve reliance on selector caching --- js/components/MainWindow/PlaylistToggleButton.js | 4 ++-- js/selectors.ts | 1 + 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/js/components/MainWindow/PlaylistToggleButton.js b/js/components/MainWindow/PlaylistToggleButton.js index 63ab5d33..3fe51319 100644 --- a/js/components/MainWindow/PlaylistToggleButton.js +++ b/js/components/MainWindow/PlaylistToggleButton.js @@ -8,14 +8,14 @@ import { toggleWindow } from "../../actionCreators"; const PlaylistToggleButton = props => (
); const mapStateToProps = state => ({ - getWindowOpen: getWindowOpen(state), + selected: getWindowOpen(state)("playlist"), }); const mapDispatchToProps = { diff --git a/js/selectors.ts b/js/selectors.ts index bcabab29..906593be 100644 --- a/js/selectors.ts +++ b/js/selectors.ts @@ -461,6 +461,7 @@ export function getLlamaMode(state: AppState) { return state.display.llama; } +// TODO: This is poorly memoized. It invalidates when a window moves. export const getWindowSizes = createSelector( getGenWindows, getDoubled,