diff --git a/packages/webamp/scripts/rollup.mjs b/packages/webamp/scripts/rollup.mjs index 8f7d536e..e8560ad0 100644 --- a/packages/webamp/scripts/rollup.mjs +++ b/packages/webamp/scripts/rollup.mjs @@ -44,6 +44,9 @@ const BUNDLES = [ file: "built/webamp.bundle.js", format: "umd", name: "Webamp", + // music-metadata uses dynamic imports, so we need to inline them + // to avoid issues with the UMD build. + inlineDynamicImports: true, }, }, { @@ -54,6 +57,9 @@ const BUNDLES = [ file: "built/webamp.bundle.min.js", format: "umd", name: "Webamp", + // music-metadata uses dynamic imports, so we need to inline them + // to avoid issues with the UMD build. + inlineDynamicImports: true, }, }, { @@ -63,6 +69,9 @@ const BUNDLES = [ output: { file: "built/webamp.bundle.min.mjs", format: "module", + // music-metadata uses dynamic imports, so we need to inline them + // to avoid issues with the UMD build. + inlineDynamicImports: true, }, }, ]; diff --git a/packages/webamp/scripts/rollupPlugins.mjs b/packages/webamp/scripts/rollupPlugins.mjs index 0c8ee1c2..ded2f57a 100644 --- a/packages/webamp/scripts/rollupPlugins.mjs +++ b/packages/webamp/scripts/rollupPlugins.mjs @@ -23,9 +23,6 @@ export function getPlugins({ minify, outputFile, vite }) { // https://rollupjs.org/troubleshooting/#warning-treating-module-as-external-dependency // TODO: We could offer a version which does not inline React/React-DOM nodeResolve(), - // Needed for music-metadata-browser in the Webamp bundle which depends upon - // being able to use some polyfillable node APIs - nodePolyfills(), typescript({ compilerOptions: { jsx: "react-jsx",