Mirrors/webamp
1
0
Fork 0
mirror of https://github.com/captbaritone/webamp.git synced 2026-07-23 10:07:35 +00:00
Code Issues Projects Releases Wiki Activity

Split out unknown component into DummyComponent

Browse source
This commit is contained in:
Jordan Eldredge 2019-09-03 07:15:32 -07:00
parent 8f1b48d186
commit a19fec2a42
1 changed files with 6 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

15
modern/src/App.js
View file

@ -507,6 +507,11 @@ const NODE_NAME_TO_COMPONENT = {
text: Text,
};
function DummyComponent({ node, children }) {
console.warn("Unknown node type", node.name);
return <>{children}</>;
}
// Given a skin XML node, pick which component to use, and render it.
function XmlNode({ node }) {
const { name } = node;
@ -521,7 +526,7 @@ function XmlNode({ node }) {
return null;
}
useJsUpdates(node);
const Component = NODE_NAME_TO_COMPONENT[name];
const Component = NODE_NAME_TO_COMPONENT[name] || DummyComponent;
const childNodes = node.children || [];
const children = childNodes.map(
(childNode, i) =>
@ -529,14 +534,6 @@ function XmlNode({ node }) {
<XmlNode key={i} node={childNode} {...childNode.attributes} />
)
);
if (Component == null) {
console.warn("Unknown node type", name);
if (childNodes.length) {
return <>{children}</>;
}
return null;
}
return (
<Component node={node} {...node.attributes}>
{children}