Handle MAKI functions being case insensitive (#825)

experiments/modern/src/debugger/Variable.js

@@ -12,7 +12,7 @@ export default function Variable({ variable }) {
       if (obj == null) {
         type = "Unknown object";
       } else {
-        type = obj.getClassName();
+        type = obj.getclassname();
       }
       break;
     case "STRING": {

experiments/modern/src/maki-interpreter/interpreter.test.js

@@ -24,7 +24,7 @@ beforeEach(() => {
   mockMessageBox = jest.fn();
   // The VM depends upon the arity of this function, so we can't use
   // `mockMessageBox` directly.
-  System.prototype.messageBox = function(a, b, c, d) {
+  System.prototype.messagebox = function(a, b, c, d) {
     mockMessageBox(...arguments);
   };
 });

experiments/modern/src/maki-interpreter/prettyPrinter.js

@@ -14,7 +14,7 @@ function printValue(value) {
       if (obj == null) {
         type = "Unknown object";
       } else {
-        type = obj.getClassName();
+        type = obj.getclassname();
       }
       break;
     case "STRING":

experiments/modern/src/maki-interpreter/virtualMachine.js

@@ -132,9 +132,11 @@ function* interpret(start, program, stack = []) {
       case 24:
       case 112: {
         const methodOffset = command.arg;
-        const { name: methodName, typeOffset: classesOffset } = methods[
+        let { name: methodName, typeOffset: classesOffset } = methods[
           methodOffset
         ];
+        methodName = methodName.toLowerCase();
+
         const klass = classes[classesOffset];
         // This is a bit awkward. Because the variables are stored on the stack
         // before the object, we have to find the number of arguments without

experiments/modern/src/runtime/Button.js

@@ -2,12 +2,12 @@ const GuiObject = require("./GuiObject");
 
 class Button extends GuiObject {
   /**
-   * getClassName()
+   * getclassname()
    *
    * Returns the class name for the object.
    * @ret The class name.
    */
-  static getClassName() {
+  static getclassname() {
     return "Button";
   }
 }

experiments/modern/src/runtime/Container.js

@@ -3,15 +3,15 @@ const { findDescendantByTypeAndId } = require("../utils");
 
 class Container extends GuiObject {
   /**
-   * getClassName()
+   * getclassname()
    *
    * Returns the class name for the object.
    * @ret The class name.
    */
-  static getClassName() {
+  static getclassname() {
     return "Container";
   }
-  getLayout(id) {
+  getlayout(id) {
     return findDescendantByTypeAndId(this, "layout", id);
   }
 }

experiments/modern/src/runtime/Group.js

@@ -2,17 +2,17 @@ const GuiObject = require("./GuiObject");
 
 class Group extends GuiObject {
   /**
-   * getClassName()
+   * getclassname()
    *
    * Returns the class name for the object.
    * @ret The class name.
    */
-  static getClassName() {
+  static getclassname() {
     return "Group";
   }
-  getObject(id) {
+  getobject(id) {
     // Not sure this is correct, but it is my understanding this is just an alias
-    return this.findObject(id);
+    return this.findobject(id);
   }
 }
 

experiments/modern/src/runtime/GuiObject.js

@@ -3,38 +3,33 @@ const { findDescendantByTypeAndId } = require("../utils");
 
 class GuiObject extends MakiObject {
   /**
-   * getClassName()
+   * getclassname()
    *
    * Returns the class name for the object.
    * @ret The class name.
    */
-  static getClassName() {
+  static getclassname() {
     return "GuiObject";
   }
-  findObject(id) {
+  findobject(id) {
     return findDescendantByTypeAndId(this, null, id);
   }
   init(newRoot) {
     newRoot.js_addChild(this);
     return this;
   }
-  setXmlParam(param, value) {
+  setxmlparam(param, value) {
     this.xmlNode.attributes[param] = value;
     return value;
   }
-  // need to force all function names to lowercase in the interpreter
-  // bad hack for now
-  setXMLParam(param, value) {
-    return this.setXmlParam(param, value);
-  }
-  getXmlParam(param) {
+  getxmlparam(param) {
     const attributes = this.xmlNode.attributes;
     if (attributes !== undefined && attributes.hasOwnProperty(param)) {
       return attributes[param];
     }
     return null;
   }
-  getParent() {
+  getparent() {
     return this.parent;
   }
 }

experiments/modern/src/runtime/Layout.js

@@ -3,15 +3,15 @@ const { findParentNodeOfType } = require("../utils");
 
 class Layout extends GuiObject {
   /**
-   * getClassName()
+   * getclassname()
    *
    * Returns the class name for the object.
    * @ret The class name.
    */
-  static getClassName() {
+  static getclassname() {
     return "Layout";
   }
-  getContainer() {
+  getcontainer() {
     return findParentNodeOfType(this, ["container"]);;
   }
 }

experiments/modern/src/runtime/MakiObject.js

@@ -43,19 +43,19 @@ class MakiObject {
   }
 
   /**
-   * getClassName()
+   * getclassname()
    *
    * Returns the class name for the object.
    * @ret The class name.
    */
-  static getClassName() {
+  static getclassname() {
     return "Object";
   }
 
   /**
    * getId()
    */
-  getId() {
+  getid() {
     throw new Error("getId not implemented");
   }
 }

experiments/modern/src/runtime/System.js

@@ -14,12 +14,12 @@ class System extends MakiObject {
   }
 
   /**
-   * getClassName()
+   * getclassname()
    *
    * Returns the class name for the object.
    * @ret The class name.
    */
-  static getClassName() {
+  static getclassname() {
     return "System";
   }
 
@@ -27,22 +27,22 @@ class System extends MakiObject {
     this.js_trigger("onScriptLoaded");
   }
 
-  getScriptGroup() {
+  getscriptgroup() {
     return this.scriptGroup;
   }
-  getContainer(id) {
+  getcontainer(id) {
     return findDescendantByTypeAndId(this.root, "container", id);
   }
-  getRuntimeVersion() {
+  getruntimeversion() {
     return "5.666";
   }
-  getToken(str, separator, tokennum) {
+  gettoken(str, separator, tokennum) {
     return "Some Token String";
   }
-  getParam() {
+  getparam() {
     return "Some String";
   }
-  messageBox(message, msgtitle, flag, notanymoreId) {
+  messagebox(message, msgtitle, flag, notanymoreId) {
     console.log({ message, msgtitle, flag, notanymoreId });
   }
 }

experiments/modern/src/runtime/WinampAbstractionLayer.js

@@ -3,12 +3,12 @@ const Group = require("./Group");
 // Needs to behavve like a group to work with top level scripts that call `getScriptGroup`
 class WinampAbstractionLayer extends Group {
   /**
-   * getClassName()
+   * getclassname()
    *
    * Returns the class name for the object.
    * @ret The class name.
    */
-  static getClassName() {
+  static getclassname() {
     return "WinampAbstractionLayer";
   }
 }