From 967a4d4feac7ab1a910c03fb42e8ca1635fa8f26 Mon Sep 17 00:00:00 2001 From: Jordan Eldredge Date: Sun, 13 May 2018 12:34:02 -0700 Subject: [PATCH] Remove analytics middleware I never found this data to be as valuable as I thought it would be. --- js/analyticsMiddleware.js | 33 --------------------------------- js/index.js | 3 +-- js/store.js | 4 +--- 3 files changed, 2 insertions(+), 38 deletions(-) delete mode 100644 js/analyticsMiddleware.js diff --git a/js/analyticsMiddleware.js b/js/analyticsMiddleware.js deleted file mode 100644 index 944853d0..00000000 --- a/js/analyticsMiddleware.js +++ /dev/null @@ -1,33 +0,0 @@ -/* global ga */ -import { - STEP_MARQUEE, - SET_SCRUB_POSITION, - SET_VOLUME, - UPDATE_TIME_ELAPSED, - SET_BALANCE, - SET_BAND_VALUE -} from "./actionTypes"; - -const excludeActionTypes = new Set([ - STEP_MARQUEE, - SET_SCRUB_POSITION, - SET_VOLUME, - UPDATE_TIME_ELAPSED, - SET_BALANCE, - SET_BAND_VALUE -]); - -export default function analyticsMiddleware() { - return next => action => { - if (!excludeActionTypes.has(action.type) && typeof ga !== "undefined") { - ga("send", { - hitType: "event", - eventCategory: "Redux Store", // Typically the object that was interacted with (e.g. 'Video') - eventAction: action.type // The type of interaction (e.g. 'play') - // eventLabel: "Fall Campaign", // Useful for categorizing events (e.g. 'Fall Campaign') - // eventValue: "Fall Campaign" // A numeric value associated with the event (e.g. 42) - }); - } - return next(action); - }; -} diff --git a/js/index.js b/js/index.js index 021743a4..3986acbc 100644 --- a/js/index.js +++ b/js/index.js @@ -19,7 +19,6 @@ import { SET_BALANCE, SET_BAND_VALUE } from "./actionTypes"; -import analyticsMiddleware from "./analyticsMiddleware"; import { hideAbout, @@ -147,7 +146,7 @@ Raven.context(() => { enableHotkeys: true, __extraWindows, __initialState: initialState, - __customMiddlewares: [analyticsMiddleware, ravenMiddleware] + __customMiddlewares: [ravenMiddleware] }); webamp.renderWhenReady(document.getElementById("app")); diff --git a/js/store.js b/js/store.js index 74f5f4ff..b9fd88d7 100644 --- a/js/store.js +++ b/js/store.js @@ -5,7 +5,6 @@ import reducer from "./reducers"; import mediaMiddleware from "./mediaMiddleware"; import { merge } from "./utils"; import { UPDATE_TIME_ELAPSED, STEP_MARQUEE } from "./actionTypes"; -import analyticsMiddleware from "./analyticsMiddleware"; const compose = composeWithDevTools({ actionsBlacklist: [UPDATE_TIME_ELAPSED, STEP_MARQUEE] @@ -40,8 +39,7 @@ const getStore = ( thunk, mediaMiddleware(media), emitterMiddleware, - ...customMiddlewares, - analyticsMiddleware + ...customMiddlewares ].filter(Boolean) ) )