Mirrors/webamp
1
0
Fork 0
mirror of https://github.com/captbaritone/webamp.git synced 2026-07-22 17:47:16 +00:00
Code Issues Projects Releases Wiki Activity

handle specific error types when fetching presets

Browse source
This commit is contained in:
jberg 2018-10-04 17:24:47 -07:00 • committed by Jordan Eldredge
parent 2421770eea
commit 93892c91e7
1 changed files with 19 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

21
js/components/MilkdropWindow/index.js
View file

@ -158,6 +158,7 @@ function presetNameFromURL(url) {
return decodeURIComponent(presetName);
} catch (e) {
// if something goes wrong parsing url, just use url as the preset name
console.error(e);
return url;
}
}
@ -182,7 +183,15 @@ async function loadInitialPreset() {
return { [presetName]: responseBody };
} catch (e) {
console.error(e);
alert(`Failed to load MilkDrop preset from ${presetUrl}`);
if (e instanceof TypeError) {
// handle URL not existing
alert(`Failed to load MilkDrop preset from ${milkdropPresetUrl}`);
} else if (e instanceof Error) {
// handle URL bad response
alert(`Unable to load MilkDrop preset from ${milkdropPresetUrl}`);
}
return null;
}
} else if (milkdropPresetUrl) {
@ -196,7 +205,15 @@ async function loadInitialPreset() {
return { [presetName]: { file: fileBlob } };
} catch (e) {
console.error(e);
alert(`Failed to load MilkDrop preset from ${milkdropPresetUrl}`);
if (e instanceof TypeError) {
// handle URL not existing
alert(`Failed to load MilkDrop preset from ${milkdropPresetUrl}`);
} else if (e instanceof Error) {
// handle URL bad response
alert(`Unable to load MilkDrop preset from ${milkdropPresetUrl}`);
}
return null;
}
}