Mirrors/webamp
1
0
Fork 0
mirror of https://github.com/captbaritone/webamp.git synced 2026-08-03 15:34:25 +00:00
Code Issues Projects Releases Wiki Activity

Handle the fact that types in Maki are case insensitive

Browse source
This commit is contained in:
Jordan Eldredge 2020-01-14 07:25:41 -08:00
parent 0c3dc49d5c
commit 881456332a
1 changed files with 17 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

22
modern/eslint/maki-method-types.js
View file

@ -34,6 +34,14 @@ const TYPE_MAP = {
},
};
function getTypeData(makiType) {
const type = TYPE_MAP[makiType.toLowerCase()];
if (type == null) {
console.warn(`Could not find type for "${makiType}"`);
}
return type;
}
module.exports = {
meta: {
docs: {
@ -89,12 +97,16 @@ module.exports = {
const { params, returnType, body } = node.value;
const sourceCode = context.getSourceCode();
const unimplemented = sourceCode
.getText(node)
.includes("unimplementedWarning");
if (unimplemented) {
return;
}
if (returnType == null) {
const expectedTypeData = TYPE_MAP[func.result];
if (
expectedTypeData != null &&
!sourceCode.getText(node).includes("unimplementedWarning")
) {
const expectedTypeData = getTypeData(func.result);
if (expectedTypeData != null) {
context.report({
node: body,
message: `Missing return type for Maki method. Expected \`${expectedTypeData.stringRepresentation}\`.`,