From 7f469cb13e5842fa4ca0b226b90daaf8cf8de9d5 Mon Sep 17 00:00:00 2001 From: Jordan Eldredge Date: Sat, 5 Jan 2019 16:37:05 -0800 Subject: [PATCH] Fix issue with trying to click and drag on full screen milkdrop. Sentry: WINAMP2-JS-PROD-BW --- js/components/WindowManager.tsx | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/js/components/WindowManager.tsx b/js/components/WindowManager.tsx index c6a95a32..ef3985a9 100644 --- a/js/components/WindowManager.tsx +++ b/js/components/WindowManager.tsx @@ -36,7 +36,7 @@ class WindowManager extends React.Component { ); const targetNode = windows.find(node => node.key === key); if (targetNode == null) { - throw new Error("Tried to move a node that does not exist"); + throw new Error(`Tried to move a node that does not exist: ${key}`); } let movingSet = new Set([targetNode]); @@ -56,6 +56,11 @@ class WindowManager extends React.Component { if (!(e.target as HTMLElement).classList.contains("draggable")) { return; } + + if (this.props.getWindowHidden(key)) { + // The user may be clicking on full screen Milkdrop. + return; + } // Prevent dragging from highlighting text. e.preventDefault();