From 7ed05cddd01352c90f79e0fc0742b4c8e7a759b9 Mon Sep 17 00:00:00 2001 From: Jordan Eldredge Date: Fri, 6 Dec 2019 21:19:28 -0800 Subject: [PATCH] Make icon hidden state a bit more explicit --- demo/js/WebampIcon.tsx | 32 +++++++++++++++++--------------- 1 file changed, 17 insertions(+), 15 deletions(-) diff --git a/demo/js/WebampIcon.tsx b/demo/js/WebampIcon.tsx index c0fb6ff5..8c9f0419 100644 --- a/demo/js/WebampIcon.tsx +++ b/demo/js/WebampIcon.tsx @@ -35,22 +35,24 @@ const WebampIcon = (props: Props) => { document.addEventListener("click", handleClick); return () => document.removeEventListener("click", handleClick); }, [selected]); + + if (hidden) { + return null; + } return ( - !hidden && ( -
{ - props.webamp.reopen(); - setHidden(true); - setSelected(false); - }} - onClick={() => setSelected(true)} - className={selected ? "selected" : ""} - > - -
Webamp
-
- ) +
{ + props.webamp.reopen(); + setHidden(true); + setSelected(false); + }} + onClick={() => setSelected(true)} + className={selected ? "selected" : ""} + > + +
Webamp
+
); };