Mirrors/webamp
1
0
Fork 0
mirror of https://github.com/captbaritone/webamp.git synced 2026-07-22 09:37:17 +00:00
Code Issues Projects Releases Wiki Activity

Work around Safari biquad filter bug!

Browse source
This commit is contained in:
Jordan Eldredge 2017-04-23 16:09:21 -07:00
parent 199bd379d4
commit 7ba3c15134
1 changed files with 9 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

13
js/media.js
View file

@ -82,7 +82,14 @@ export default {
this._leftGain.connect(this._chanMerge, 0, 0);
this._rightGain.connect(this._chanMerge, 0, 1);
const output = this._chanMerge;
// Safari, both mobile and desktop, has a bug where
// connecting a merger node to biquad filter node
// will cause it to crash. Adding this dummy node
// works around this bug.
const dummyNode = this._context.createAnalyser();
this._chanMerge.connect(dummyNode);
let output = dummyNode;
this.bands = {};
BANDS.forEach((band, i) => {
@ -101,11 +108,9 @@ export default {
}
filter.frequency.value = band;
filter.gain.value = 0;
/*
Disable this while we wait for Safari to fix its bug.
output.connect(filter);
output = filter;
*/
});
output.connect(this._gainNode);