From 799d29ccdfa6b49141540430621d03b12f4e43a2 Mon Sep 17 00:00:00 2001
From: Jordan Eldredge <jordan@jordaneldredge.com>
Date: Mon, 11 Jun 2018 22:14:14 -0700
Subject: [PATCH] Refactor visualization style

---
 js/components/Visualizer.js | 14 +++++++-------
 js/constants.js             | 12 ++++++++++++
 js/reducers/display.js      |  9 ++++++---
 3 files changed, 25 insertions(+), 10 deletions(-)

diff --git a/js/components/Visualizer.js b/js/components/Visualizer.js
index 2c54768d..5e5a274d 100644
--- a/js/components/Visualizer.js
+++ b/js/components/Visualizer.js
@@ -3,9 +3,8 @@ import { connect } from "react-redux";
 
 import { toggleVisualizerStyle } from "../actionCreators";
 import { getWindowShade } from "../selectors";
+import { VISUALIZER_ORDER, VISUALIZERS } from "../constants";
 
-const OSCILLOSCOPE = 1;
-const BAR = 2;
 const PIXEL_DENSITY = 2;
 const BAR_WIDTH = 6;
 const GRADIENT_COLOR_COUNT = 16;
@@ -75,11 +74,11 @@ class Visualizer extends React.Component {
     // update.
     this.preRenderBg();
     this.preRenderBar();
-    if (this.props.style === OSCILLOSCOPE) {
+    if (this.props.style === VISUALIZERS.OSCILLOSCOPE) {
       this.props.analyser.fftSize = 2048;
       this.bufferLength = this.props.analyser.fftSize;
       this.dataArray = new Uint8Array(this.bufferLength);
-    } else if (this.props.style === BAR) {
+    } else if (this.props.style === VISUALIZERS.BAR) {
       this.props.analyser.fftSize = 64; // Must be a power of two
       // Number of bins/bars we get
       this.bufferLength = this.props.analyser.frequencyBinCount;
@@ -152,9 +151,9 @@ class Visualizer extends React.Component {
 
   paintFrame() {
     this.clear();
-    if (this.props.style === OSCILLOSCOPE) {
+    if (this.props.style === VISUALIZERS.OSCILLOSCOPE) {
       this._paintOscilloscopeFrame();
-    } else if (this.props.style === BAR) {
+    } else if (this.props.style === VISUALIZERS.BAR) {
       this._paintBarFrame();
     }
   }
@@ -229,6 +228,7 @@ class Visualizer extends React.Component {
   }
 
   render() {
+    console.log(this.props.style);
     const { width, height } = this.props;
     return (
       <canvas
@@ -245,7 +245,7 @@ class Visualizer extends React.Component {
 
 const mapStateToProps = state => ({
   colors: state.display.skinColors,
-  style: state.display.visualizerStyle,
+  style: VISUALIZER_ORDER[state.display.visualizerStyle],
   width: getWindowShade(state, "main") ? 38 : 76,
   height: getWindowShade(state, "main") ? 5 : 16,
   status: state.media.status,
diff --git a/js/constants.js b/js/constants.js
index 1374e7c8..7954f946 100644
--- a/js/constants.js
+++ b/js/constants.js
@@ -29,3 +29,15 @@ export const TRACK_HEIGHT = 13;
 export const LETTERS = "ABCDEFGHIJKLMNOPQRSTUVWXYZ".split("");
 
 export const DEFAULT_SKIN = baseSkin;
+
+export const VISUALIZERS = {
+  OSCILLOSCOPE: "OSCILLOSCOPE",
+  BAR: "BAR",
+  NONE: "NONE"
+};
+
+export const VISUALIZER_ORDER = [
+  VISUALIZERS.BAR,
+  VISUALIZERS.OSCILLOSCOPE, // TODO: Verify the order
+  VISUALIZERS.NONE
+];
diff --git a/js/reducers/display.js b/js/reducers/display.js
index ae8eb22d..4aebc95f 100644
--- a/js/reducers/display.js
+++ b/js/reducers/display.js
@@ -10,7 +10,7 @@ import {
   SET_PLAYLIST_SCROLL_POSITION,
   LOADED
 } from "../actionTypes";
-import { DEFAULT_SKIN } from "../constants";
+import { DEFAULT_SKIN, VISUALIZER_ORDER } from "../constants";
 
 const defaultDisplayState = {
   doubled: false,
@@ -24,7 +24,7 @@ const defaultDisplayState = {
   skinCursors: null,
   skinPlaylistStyle: null,
   skinRegion: {},
-  visualizerStyle: 2,
+  visualizerStyle: 0, // Index into VISUALIZER_ORDER
   playlistScrollPosition: 0,
   skinGenLetterWidths: null // TODO: Get the default value for this?
 };
@@ -57,7 +57,10 @@ const display = (state = defaultDisplayState, action) => {
         skinGenLetterWidths: action.skinGenLetterWidths
       };
     case TOGGLE_VISUALIZER_STYLE:
-      return { ...state, visualizerStyle: (state.visualizerStyle + 1) % 3 };
+      return {
+        ...state,
+        visualizerStyle: (state.visualizerStyle + 1) % VISUALIZER_ORDER.length
+      };
     case SET_PLAYLIST_SCROLL_POSITION:
       return { ...state, playlistScrollPosition: action.position };
     default: