From 73bc040136279cc39cc923dc69fbe5e250f2728c Mon Sep 17 00:00:00 2001 From: Jordan Eldredge Date: Fri, 27 Sep 2019 08:11:51 -0700 Subject: [PATCH] Fix comment to reflect current knowledge --- modern/src/maki-interpreter/tools/extract-functions.js | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/modern/src/maki-interpreter/tools/extract-functions.js b/modern/src/maki-interpreter/tools/extract-functions.js index 82d04d88..53e80067 100755 --- a/modern/src/maki-interpreter/tools/extract-functions.js +++ b/modern/src/maki-interpreter/tools/extract-functions.js @@ -76,10 +76,9 @@ async function main(parentDir) { const paths = await findWals(parentDir); const callCounts = []; - // getCallCountsFromWal loads the skin into memory, in order to avoid loading - // all skins into memory, which leads to us running out or memory, we - // purposefully run them syncronously. If we find this is too slow we could do - // something like https://www.npmjs.com/package/p-limit + // Originally we moved to doing one skin at a time because we thougth it was + // causing memory issues, now we know it's not, but it's still faster to do + // one at a time for some reason. ¯\_(ツ)_/¯ for (const walPath of paths) { try { const fileName = path.basename(walPath);