From 6ee338fc765c70e2bf861cafdae98b4d404b0aec Mon Sep 17 00:00:00 2001 From: Jordan Eldredge Date: Sat, 10 Mar 2018 15:14:29 -0800 Subject: [PATCH] Remove event listener I was a good boy, and made sure to remove my mouse move event listener when the user's mouse came up. Sadly, I didn't then _also_ remove the mouse up event listener. This meant that after clicking a few times, the whole app would stall quite a bit any time your mouse came up. --- js/components/WindowManager.js | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/js/components/WindowManager.js b/js/components/WindowManager.js index 7778fb21..db991f8b 100644 --- a/js/components/WindowManager.js +++ b/js/components/WindowManager.js @@ -166,9 +166,12 @@ class WindowManager extends React.Component { this.setState(stateDiff); }; - window.addEventListener("mouseup", () => { + const removeListeners = () => { window.removeEventListener("mousemove", handleMouseMove); - }); + window.removeEventListener("mouseup", removeListeners); + }; + + window.addEventListener("mouseup", removeListeners); window.addEventListener("mousemove", handleMouseMove); }