From 6e5e701f6d44c2d2200c4c8406d4c026dc700dbf Mon Sep 17 00:00:00 2001 From: Jordan Eldredge Date: Thu, 5 Sep 2019 06:12:34 -0700 Subject: [PATCH] Add some missing method return types --- modern/src/maki-interpreter/objects.test.js | 1 - modern/src/runtime/System.ts | 19 +++++++++---------- 2 files changed, 9 insertions(+), 11 deletions(-) diff --git a/modern/src/maki-interpreter/objects.test.js b/modern/src/maki-interpreter/objects.test.js index 7a839d52..94f59189 100644 --- a/modern/src/maki-interpreter/objects.test.js +++ b/modern/src/maki-interpreter/objects.test.js @@ -173,7 +173,6 @@ Set { "System.removepath", "System.getpath", "System.getextension", - "System.random", "System.setpublicstring", "System.setpublicint", "System.getpublicstring", diff --git a/modern/src/runtime/System.ts b/modern/src/runtime/System.ts index d95f0af7..1e11aa5f 100644 --- a/modern/src/runtime/System.ts +++ b/modern/src/runtime/System.ts @@ -508,7 +508,7 @@ class System extends MakiObject { return encodeURI(url); } - removepath(str: string) { + removepath(str: string): string { unimplementedWarning("removepath"); return; } @@ -523,7 +523,7 @@ class System extends MakiObject { return; } - sin(value: number) { + sin(value: number): number { return Math.sin(value); } @@ -543,7 +543,7 @@ class System extends MakiObject { return Math.acos(value); } - atan(value: number) { + atan(value: number): number { return Math.atan(value); } @@ -555,20 +555,19 @@ class System extends MakiObject { return Math.pow(value, pvalue); } - sqr(value: number) { + sqr(value: number): number { return Math.pow(value, 2); } - sqrt(value: number) { + sqrt(value: number): number { return Math.sqrt(value); } - random(max: number) { - unimplementedWarning("random"); - return; + random(max: number): number { + return Math.floor(Math.random() * max); } - setprivatestring(section: string, item: string, value: string) { + setprivatestring(section: string, item: string, value: string): void { if (!this._privateString.has(section)) { this._privateString.set(section, new Map([[item, value]])); } else { @@ -576,7 +575,7 @@ class System extends MakiObject { } } - getprivatestring(section: string, item: string, defvalue: string) { + getprivatestring(section: string, item: string, defvalue: string): string { if (!this._privateString.has(section)) { return defvalue; }