From 624292e457e1f71b47028f61d7ccb4bf2df275db Mon Sep 17 00:00:00 2001 From: Jordan Eldredge Date: Sat, 11 Apr 2015 11:03:50 -0700 Subject: [PATCH] Fix loading skins from context menu I had forgotten to include MyFile in context.js. Additionally, for some reason `self` was out of scope in the callback. --- js/context.js | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/js/context.js b/js/context.js index ca5f5a17..6dd03337 100644 --- a/js/context.js +++ b/js/context.js @@ -1,4 +1,5 @@ -define({ +define(['file'], function(MyFile) { +return { init: function(winamp) { this.winamp = winamp; @@ -17,7 +18,7 @@ define({ var skinSelectNodes = document.getElementsByClassName('skin-select'); for(var i = 0; i < skinSelectNodes.length; i++) { - skinSelectNodes[i].onclick = this._loadSkin; + skinSelectNodes[i].onclick = this._loadSkin.bind(this); } document.getElementById('context-play-file').onclick = function(event) { @@ -33,10 +34,10 @@ define({ }; }, - _loadSkin: function() { + _loadSkin: function(event) { var skinFile = new MyFile(); - skinFile.setUrl(this.dataset.skinUrl); - self.winamp.setSkin(skinFile); + skinFile.setUrl(event.target.dataset.skinUrl); + this.winamp.setSkin(skinFile); } - +}; });