From 5fd96ef40eaeaf98a992cfba7d30aac2cceaeaa9 Mon Sep 17 00:00:00 2001 From: Jordan Eldredge Date: Tue, 22 Oct 2019 08:28:51 -0700 Subject: [PATCH] Turn ESLint rules back on for /modern --- modern/.eslintrc | 4 +--- modern/src/App.js | 2 +- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/modern/.eslintrc b/modern/.eslintrc index da44201e..2fef56ea 100644 --- a/modern/.eslintrc +++ b/modern/.eslintrc @@ -1,8 +1,6 @@ { "rules": { // TODO: Turn these all back on - "camelcase": "off", - "react-hooks/rules-of-hooks": "off", - "react-hooks/exhaustive-deps": "off" + "camelcase": "off" } } diff --git a/modern/src/App.js b/modern/src/App.js index d101c832..1d6c8154 100644 --- a/modern/src/App.js +++ b/modern/src/App.js @@ -672,7 +672,7 @@ function Modern() { const defaultSkinUrl = getSkinUrlFromQueryParams() || skinUrls[0]; setSkinUrl(defaultSkinUrl); dispatch(Actions.gotSkinUrl(defaultSkinUrl, store)); - }, [store]); + }, [store, dispatch]); if (root == null) { return ; }