From 4f66c4e60fba61471d8434d494b54661cf3ceb9d Mon Sep 17 00:00:00 2001 From: Jordan Eldredge Date: Mon, 3 Dec 2018 17:37:40 -0800 Subject: [PATCH] Upgrade Webamp to support disposal --- package.json | 2 +- src/WebampComponent.js | 10 +--------- 2 files changed, 2 insertions(+), 10 deletions(-) diff --git a/package.json b/package.json index 897bfd70..69e90d45 100644 --- a/package.json +++ b/package.json @@ -20,7 +20,7 @@ "redux-observable": "^1.0.0", "rxjs": "^6.3.3", "shell-escape": "^0.2.0", - "webamp": "^1.3.0-beta.0" + "webamp": "^1.3.0-beta.1" }, "scripts": { "start": "react-scripts start", diff --git a/src/WebampComponent.js b/src/WebampComponent.js index a8840f80..324ce3ef 100644 --- a/src/WebampComponent.js +++ b/src/WebampComponent.js @@ -17,15 +17,7 @@ class WebampComponent extends React.Component { this._disposable.dispose(); if (this._webamp) { - if (this._webamp.dispose) { - this._webamp.dispose(); - } else { - // TODO: Remove this once we upgrade Webamp - const close = document.querySelector("#webamp #close"); - if (close != null) { - close.click(); - } - } + this._webamp.dispose(); } }