Mirrors/webamp
1
0
Fork 0
mirror of https://github.com/captbaritone/webamp.git synced 2026-07-25 02:57:30 +00:00
Code Issues Projects Releases Wiki Activity

Fix skin select box value (#940)

Browse source 
* fix skin select box value

* move skinUrl into local component state
This commit is contained in:
jberg 2019-10-11 16:15:53 -07:00 • committed by Jordan Eldredge
parent 8d8dc19a3c
commit 4daad6abed
1 changed files with 4 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

4
modern/src/App.js
View file

@ -663,8 +663,10 @@ function Modern() {
const dispatch = useDispatch();
const store = useStore();
const root = useSelector(Selectors.getMakiTree);
const [skinUrl, setSkinUrl] = React.useState(null);
React.useEffect(() => {
const defaultSkinUrl = getSkinUrlFromQueryParams() || skinUrls[0];
setSkinUrl(defaultSkinUrl);
dispatch(Actions.gotSkinUrl(defaultSkinUrl, store));
}, [store]);
if (root == null) {
@ -682,8 +684,10 @@ function Modern() {
</DropTarget>
<select
style={{ position: "absolute", bottom: 0 }}
value={skinUrl}
onChange={e => {
const newSkinUrl = e.target.value;
setSkinUrl(newSkinUrl);
// TODO: This should really go in a middleware somewhere.
setSkinUrlToQueryParams(newSkinUrl);
dispatch(Actions.gotSkinUrl(newSkinUrl, store));