From 4130b4eafb64102aa4fe0e870024b2bfef663211 Mon Sep 17 00:00:00 2001
From: Jordan Eldredge <jordan@jordaneldredge.com>
Date: Sun, 17 May 2020 20:22:33 -0700
Subject: [PATCH] Resolve lint errors

---
 .eslintrc                                               | 1 -
 experiments/skin-database/discord-bot/commands/stats.ts | 2 +-
 experiments/skin-database/index.js                      | 2 +-
 experiments/skin-database/s3.js                         | 4 ++--
 modern/src/App.js                                       | 3 ++-
 5 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/.eslintrc b/.eslintrc
index 666c8e53..5e1fe9b0 100644
--- a/.eslintrc
+++ b/.eslintrc
@@ -162,7 +162,6 @@
     "import/no-duplicates": "error",
     "import/no-extraneous-dependencies": "error",
     "import/no-named-as-default-member": "error",
-    "import/no-unresolved": "error",
     "react-hooks/rules-of-hooks": "error",
     "react-hooks/exhaustive-deps": "error"
   }
diff --git a/experiments/skin-database/discord-bot/commands/stats.ts b/experiments/skin-database/discord-bot/commands/stats.ts
index ee7d6f78..d4474e54 100644
--- a/experiments/skin-database/discord-bot/commands/stats.ts
+++ b/experiments/skin-database/discord-bot/commands/stats.ts
@@ -3,7 +3,7 @@ import { Message } from "discord.js";
 import { getStats, getClassicSkinCount } from "../../data/skins";
 
 async function handler(message: Message): Promise<void> {
-  let classic = await getClassicSkinCount();
+  const classic = await getClassicSkinCount();
   const { tweeted, approved, rejected, tweetable } = await getStats();
   await message.channel.send(`Unique Skins: ${classic.toLocaleString()}
 Tweeted: ${tweeted.toLocaleString()}
diff --git a/experiments/skin-database/index.js b/experiments/skin-database/index.js
index 7f6a7475..ea476cbe 100644
--- a/experiments/skin-database/index.js
+++ b/experiments/skin-database/index.js
@@ -44,7 +44,7 @@ app.post("/skins/", async (req, res) => {
     res.status(500).send({ error: "No file supplied" });
     return;
   }
-  result = await addSkinFromBuffer(upload.data, upload.name, "Web API");
+  const result = await addSkinFromBuffer(upload.data, upload.name, "Web API");
   res.json({ ...result, filename: upload.name });
 });
 
diff --git a/experiments/skin-database/s3.js b/experiments/skin-database/s3.js
index 1be78a2e..28c53ee0 100644
--- a/experiments/skin-database/s3.js
+++ b/experiments/skin-database/s3.js
@@ -36,7 +36,7 @@ function putSkin(md5, buffer) {
     const key = `skins/${md5}.wsz`;
     s3.putObject(
       { Bucket: bucketName, Key: key, Body: buffer, ACL: "public-read" },
-      err => {
+      (err) => {
         if (err) {
           rejectPromise(err);
           return;
@@ -54,7 +54,7 @@ function putScreenshot(md5, buffer) {
     const key = `screenshots/${md5}.png`;
     s3.putObject(
       { Bucket: bucketName, Key: key, Body: buffer, ACL: "public-read" },
-      err => {
+      (err) => {
         if (err) {
           rejectPromise(err);
           return;
diff --git a/modern/src/App.js b/modern/src/App.js
index 08c9ec61..d96f21a3 100644
--- a/modern/src/App.js
+++ b/modern/src/App.js
@@ -629,12 +629,14 @@ function MakiChildren({ makiObject }) {
 
 // Given a skin XML node, pick which component to use, and render it.
 const Maki = React.memo(({ makiObject }) => {
+  useJsUpdates(makiObject);
   let { name } = makiObject;
   if (name == null) {
     // name is null is likely a comment
     return null;
   }
   name = name.toLowerCase();
+
   if (
     name === "groupdef" ||
     name === "elements" ||
@@ -646,7 +648,6 @@ const Maki = React.memo(({ makiObject }) => {
     // these nodes dont need to be rendered
     return null;
   }
-  useJsUpdates(makiObject);
   const Component = NODE_NAME_TO_COMPONENT[name] || DummyComponent;
   return <Component makiObject={makiObject} />;
 });