From 3d8876f77172fe2f475b05f45d5e23aebb40c735 Mon Sep 17 00:00:00 2001
From: Jordan Eldredge <jordan@jordaneldredge.com>
Date: Sun, 9 Jun 2019 00:38:43 -0400
Subject: [PATCH] Small improvements

---
 experiments/skin-database/cli.js                          | 2 ++
 experiments/skin-database/discord-bot/utils.js            | 3 ++-
 .../skin-database/tasks/fetchInternetArchiveMetadata.js   | 8 +++++++-
 3 files changed, 11 insertions(+), 2 deletions(-)

diff --git a/experiments/skin-database/cli.js b/experiments/skin-database/cli.js
index 2d9f90a0..9d696f50 100755
--- a/experiments/skin-database/cli.js
+++ b/experiments/skin-database/cli.js
@@ -4,6 +4,7 @@ const findTweetableSkin = require("./tasks/findTweetableSkins");
 const fetchInternetArchiveMetadata = require("./tasks/fetchInternetArchiveMetadata");
 const path = require("path");
 const Skins = require("./data/skins");
+const db = require("./db");
 
 const { spawn } = require("child_process");
 
@@ -68,6 +69,7 @@ async function main() {
     default:
       console.log(`Unknown command ${argv._[0]}`);
   }
+  // await db.close();
 }
 
 main();
diff --git a/experiments/skin-database/discord-bot/utils.js b/experiments/skin-database/discord-bot/utils.js
index 63c19b84..ddf3abb5 100644
--- a/experiments/skin-database/discord-bot/utils.js
+++ b/experiments/skin-database/discord-bot/utils.js
@@ -35,7 +35,8 @@ async function postSkin({ md5, title, dest }) {
     .setImage(screenshotUrl);
 
   if (readmeText) {
-    embed.setDescription(`\`\`\`${readmeText}\`\`\``);
+    // Trim the readme since Discord will reject it otherwise.
+    embed.setDescription(`\`\`\`${readmeText.slice(0, 2000)}\`\`\``);
   }
   if (averageColor) {
     try {
diff --git a/experiments/skin-database/tasks/fetchInternetArchiveMetadata.js b/experiments/skin-database/tasks/fetchInternetArchiveMetadata.js
index 9315777f..4000cec3 100644
--- a/experiments/skin-database/tasks/fetchInternetArchiveMetadata.js
+++ b/experiments/skin-database/tasks/fetchInternetArchiveMetadata.js
@@ -22,11 +22,13 @@ async function fetchAllMetadata(limit) {
       },
     }
   );
+  console.log(`Found ${items.length} missing metadata`);
   await Promise.all(
     items.map(item => {
       return fetchMetadata(item.identifier);
     })
   );
+  return items.length;
 }
 // TODO: Refetch collections from:
 // https://archive.org/advancedsearch.php?q=collection%3Awinampskins&fl%5B%5D=identifier&rows=100000&page=1&output=json
@@ -36,7 +38,11 @@ module.exports = async function main() {
   async function go() {
     console.log("Gonna fetch some more");
     try {
-      await fetchAllMetadata(500);
+      const count = await fetchAllMetadata(500);
+      if(count < 1) {
+        console.log("Done.");
+        return;
+      }
     } catch (e) {
       console.error(e);
       delay += 60000;