Minify css using postcss (#732)

* Minify css using postcss

* Optimize data uris as build time

config/webpack.library.js

@@ -11,7 +11,20 @@ module.exports = {
     rules: [
       {
         test: /\.css$/,
-        use: ["style-loader", "css-loader"]
+        use: [
+          "style-loader",
+          { loader: "css-loader", options: { importLoaders: 1 } },
+          // We really only need this in prod. We could find a way to disable it in dev.
+          {
+            loader: "postcss-loader",
+            options: {
+              plugins: [
+                require("cssnano"),
+                require("../scripts/postcss-optimize-data-uri-pngs")
+              ]
+            }
+          }
+        ]
       },
       {
         test: /\.(js|ts|tsx)$/,

demo/config/webpack.common.js

@@ -11,7 +11,20 @@ module.exports = {
     rules: [
       {
         test: /\.css$/,
-        use: ["style-loader", "css-loader"]
+        use: [
+          "style-loader",
+          { loader: "css-loader", options: { importLoaders: 1 } },
+          // We really only need this in prod. We could find a way to disable it in dev.
+          {
+            loader: "postcss-loader",
+            options: {
+              plugins: [
+                require("cssnano"),
+                require("../../scripts/postcss-optimize-data-uri-pngs")
+              ]
+            }
+          }
+        ]
       },
       {
         test: /\.(js|ts|tsx)?$/,

js/webampLazy.tsx

@@ -34,7 +34,7 @@ import {
 } from "./actionTypes";
 import Emitter from "./emitter";
 
-import "../css/base-skin.min.css";
+import "../css/base-skin.css";
 import { SerializedStateV1 } from "./serializedStates/v1Types";
 import Disposable from "./Disposable";
 

package.json

@@ -79,6 +79,8 @@
     "classnames": "^2.2.5",
     "copy-webpack-plugin": "^4.6.0",
     "css-loader": "^1.0.1",
+    "cssnano": "^4.1.10",
+    "data-uri-to-buffer": "^2.0.0",
     "eslint": "4.16.0",
     "eslint-config-prettier": "^2.3.0",
     "eslint-plugin-import": "^2.7.0",
@@ -92,6 +94,8 @@
     "html-webpack-plugin": "^3.2.0",
     "http-server": "^0.11.1",
     "idb-kv-store": "^4.4.0",
+    "imagemin": "^6.1.0",
+    "imagemin-optipng": "^6.0.0",
     "invariant": "^2.2.3",
     "jest": "^23.5.0",
     "jest-image-snapshot": "^2.4.1",
@@ -99,8 +103,11 @@
     "jest-puppeteer": "^3.0.1",
     "jest-runner-eslint": "^0.4.0",
     "jszip": "^3.1.3",
+    "lodash": "^4.17.11",
     "milkdrop-preset-converter-aws": "^0.1.6",
     "music-metadata-browser": "^0.6.1",
+    "postcss": "^7.0.14",
+    "postcss-loader": "^3.0.0",
     "prettier": "^1.16.0",
     "prop-types": "^15.5.10",
     "puppeteer": "^1.4.0",
@@ -139,8 +146,5 @@
       "config/jest.*.js"
     ]
   },
-  "prettier": {},
-  "dependencies": {
-    "lodash": "^4.17.11"
-  }
+  "prettier": {}
 }

scripts/postcss-optimize-data-uri-pngs.js

@@ -0,0 +1,37 @@
+const postcss = require("postcss");
+const dataUriToBuffer = require("data-uri-to-buffer");
+const imagemin = require("imagemin");
+const imageminOptipng = require("imagemin-optipng");
+
+const DATA_URL_REGEX = new RegExp(/url\((data:image\/png;base64,.+)\)/gi);
+const DATA_URL_PROPS_REGEX = /^(background(?:-image)?)|(content)|(cursor)/;
+
+async function optimizeDataUri(dataUri) {
+  const buffer = dataUriToBuffer(dataUri);
+  const optimized = await imagemin.buffer(buffer, {
+    use: [imageminOptipng()]
+  });
+  return `data:image/png;base64,${optimized.toString("base64")}`;
+}
+
+module.exports = postcss.plugin("postcss-optimize-data-uri-pngs", () => {
+  return async function(css) {
+    // walkDecls does not let us work async, so we collect the async work we
+    // need to do here, and await it at the end
+    const promisesFactories = [];
+    css.walkDecls(DATA_URL_PROPS_REGEX, decl => {
+      let matches;
+      // WTF JavaScript. This is the worst API for iterating RegEx matches.
+      while ((matches = DATA_URL_REGEX.exec(decl.value))) {
+        const [, dataUri] = matches;
+        promisesFactories.push(async () => {
+          decl.value = decl.value.replace(
+            dataUri,
+            await optimizeDataUri(dataUri)
+          );
+        });
+      }
+    });
+    await Promise.all(promisesFactories.map(p => p()));
+  };
+});

scripts/postcss-optimize-data-uri-pngs.test.js

@@ -0,0 +1,10 @@
+const fs = require("fs");
+const postcss = require("postcss");
+
+const plugin = require("./postcss-optimize-data-uri-pngs");
+
+const css = fs.readFileSync("./css/base-skin.css", "utf8");
+it("does something", async () => {
+  const result = await postcss([plugin({})]).process(css);
+  expect(result.css.length).toBeLessThan(css.length);
+});