Mirrors/webamp
1
0
Fork 0
mirror of https://github.com/captbaritone/webamp.git synced 2026-01-23 10:15:31 +00:00
Code Issues Projects Releases Wiki Activity

Scope the allowed preset urls

Browse source 
Relates to #750
This commit is contained in:
Jordan Eldredge 2019-03-15 16:44:37 -07:00
parent 7f98705363
commit 26613512cf
1 changed files with 23 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

29
demo/js/butterchurnOptions.ts
View file

@ -1,5 +1,12 @@
import { ButterchurnOptions } from "../../js/types";
const KNOWN_PRESET_URLS_REGEXES = [
/^https:\/\/unpkg\.com\/butterchurn-presets\/.*\.json$/,
/^https:\/\/unpkg\.com\/butterchurn-presets-weekly\/.*\.json$/,
/^https:\/\/archive\.org\/cors\/md_.*\.json$/,
/^https:\/\/s3-us-east-2\.amazonaws\.com\/butterchurn-presets\/.*\.json$/
];
function presetNameFromURL(url: string) {
try {
const urlParts = url.split("/");
@ -35,12 +42,22 @@ export function getButterchurnOptions(
const butterchurnPresetUrlParam = params.get("butterchurnPresetUrl");
const milkdropPresetUrl = params.get("milkdropPresetUrl");
if (butterchurnPresetUrlParam) {
return [
{
name: presetNameFromURL(butterchurnPresetUrlParam),
butterchurnPresetUrl: butterchurnPresetUrlParam
}
];
if (
!KNOWN_PRESET_URLS_REGEXES.some(pattern =>
pattern.test(butterchurnPresetUrlParam)
)
) {
console.error(
"Unsupported URL passed as butterchurnPresetUrl query param."
);
} else {
return [
{
name: presetNameFromURL(butterchurnPresetUrlParam),
butterchurnPresetUrl: butterchurnPresetUrlParam
}
];
}
} else if (milkdropPresetUrl) {
throw new Error("We still need to implement this");
}