mirror of
https://github.com/transloadit/uppy.git
synced 2026-07-21 01:15:35 +00:00
24b584ff74
The `#uploadParts` function calls itself after any part is uploaded. It also determines which new chunks to upload based on their `state.busy` value. This introduced a race condition, as `state.busy` was being set to false in the XHR event handlers. So if one part were to complete while another part had finished the XHR request, but not yet completed, then an upload for that second part would be started again, despite the fact that the previous upload was still in progress. Multiple uploads for the same part at the same time cause numerous issues, and should never happen. This is especially noticeable when an XHR request fails. `#uploadPart` is wrapped in `#retryable`, so the part will be retried, however, for the entire `retryDelay`, the chunk's `state.busy` value would be false, meaning that if any other part completed, this part would be uploaded again, despite the fact that the upload is already ongoing. To fix this, this commit moves setting `state.busy` to the `before` and `after` functions of the `#retryable` call, so a part will remain `busy` for the entire time it is being uploaded/retried. |
||
|---|---|---|
| .. | ||
| angular | ||
| audio | ||
| aws-s3 | ||
| aws-s3-multipart | ||
| box | ||
| companion | ||
| companion-client | ||
| compressor | ||
| core | ||
| dashboard | ||
| drag-drop | ||
| drop-target | ||
| dropbox | ||
| file-input | ||
| form | ||
| golden-retriever | ||
| google-drive | ||
| image-editor | ||
| informer | ||
| locales | ||
| onedrive | ||
| progress-bar | ||
| provider-views | ||
| react | ||
| react-native | ||
| redux-dev-tools | ||
| remote-sources | ||
| robodog | ||
| screen-capture | ||
| status-bar | ||
| store-default | ||
| store-redux | ||
| svelte | ||
| thumbnail-generator | ||
| transloadit | ||
| tus | ||
| unsplash | ||
| url | ||
| utils | ||
| vue | ||
| webcam | ||
| xhr-upload | ||
| zoom | ||