From e6efc0ecc5fcbc11300aa02565a2aa0535b1df8e Mon Sep 17 00:00:00 2001 From: Antoine du Hamel Date: Wed, 22 May 2024 10:25:23 +0300 Subject: [PATCH] @uppy/svelte: do not attempt removing plugin before it's created (#5186) --- packages/@uppy/svelte/src/components/Dashboard.svelte | 2 +- packages/@uppy/svelte/src/components/DashboardModal.svelte | 2 +- packages/@uppy/svelte/src/components/DragDrop.svelte | 2 +- packages/@uppy/svelte/src/components/ProgressBar.svelte | 2 +- packages/@uppy/svelte/src/components/StatusBar.svelte | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/packages/@uppy/svelte/src/components/Dashboard.svelte b/packages/@uppy/svelte/src/components/Dashboard.svelte index a986e6cd9..9bcc51bd3 100644 --- a/packages/@uppy/svelte/src/components/Dashboard.svelte +++ b/packages/@uppy/svelte/src/components/Dashboard.svelte @@ -23,7 +23,7 @@ plugin = uppy.getPlugin(options.id) as DashboardPlugin; } const uninstallPlugin = (uppyInstance: Uppy = uppy) => { - uppyInstance.removePlugin(plugin); + if (plugin != null) uppyInstance.removePlugin(plugin); } onMount(() => installPlugin()) diff --git a/packages/@uppy/svelte/src/components/DashboardModal.svelte b/packages/@uppy/svelte/src/components/DashboardModal.svelte index 63182254e..c795e75b8 100644 --- a/packages/@uppy/svelte/src/components/DashboardModal.svelte +++ b/packages/@uppy/svelte/src/components/DashboardModal.svelte @@ -26,7 +26,7 @@ if(open) plugin.openModal(); } const uninstallPlugin = (uppyInstance: Uppy = uppy) => { - uppyInstance.removePlugin(plugin); + if (plugin != null) uppyInstance.removePlugin(plugin); } onMount(() => installPlugin()) diff --git a/packages/@uppy/svelte/src/components/DragDrop.svelte b/packages/@uppy/svelte/src/components/DragDrop.svelte index d63600460..ce0f1aa39 100644 --- a/packages/@uppy/svelte/src/components/DragDrop.svelte +++ b/packages/@uppy/svelte/src/components/DragDrop.svelte @@ -21,7 +21,7 @@ plugin = uppy.getPlugin(options.id) as DragDropPlugin; } const uninstallPlugin = (uppyInstance: Uppy = uppy) => { - uppyInstance.removePlugin(plugin); + if (plugin != null) uppyInstance.removePlugin(plugin); } onMount(() => installPlugin()) diff --git a/packages/@uppy/svelte/src/components/ProgressBar.svelte b/packages/@uppy/svelte/src/components/ProgressBar.svelte index 316fc0c78..ab30f8d08 100644 --- a/packages/@uppy/svelte/src/components/ProgressBar.svelte +++ b/packages/@uppy/svelte/src/components/ProgressBar.svelte @@ -21,7 +21,7 @@ plugin = uppy.getPlugin(options.id) as ProgressBarPlugin; } const uninstallPlugin = (uppyInstance: Uppy = uppy) => { - uppyInstance.removePlugin(plugin); + if (plugin != null) uppyInstance.removePlugin(plugin); } onMount(() => installPlugin()) diff --git a/packages/@uppy/svelte/src/components/StatusBar.svelte b/packages/@uppy/svelte/src/components/StatusBar.svelte index 04c506926..a96cbdf53 100644 --- a/packages/@uppy/svelte/src/components/StatusBar.svelte +++ b/packages/@uppy/svelte/src/components/StatusBar.svelte @@ -21,7 +21,7 @@ plugin = uppy.getPlugin(options.id) as StatusBarPlugin; } const uninstallPlugin = (uppyInstance: Uppy = uppy) => { - uppyInstance.removePlugin(plugin); + if (plugin != null) uppyInstance.removePlugin(plugin); } onMount(() => installPlugin())