Mirrors/uppy
1
0
Fork 0
mirror of https://github.com/transloadit/uppy.git synced 2026-07-17 16:50:22 +00:00
Code Issues Projects Releases Wiki Activity

Merge 435a267a8e into 0b1f79c90d

Browse source
This commit is contained in:
Jonathan Wong 2026-07-10 15:24:23 +03:00 • committed by GitHub
commit c9f6d9aa36
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 11 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

16
packages/@uppy/aws-s3/src/index.ts
View file

@ -770,11 +770,17 @@ export default class AwsS3Multipart<
)
}
if (etag == null) {
console.error(
'@uppy/aws-s3: Could not read the ETag header. This likely means CORS is not configured correctly on the S3 Bucket. See https://uppy.io/docs/aws-s3/#setting-up-your-s3-bucket',
)
return
}
// ETag is only strictly required for multipart uploads (to complete the upload).
// For non-multipart uploads (single PUT/POST), it's just metadata.
// We warn but don't block completion for non-multipart uploads.
console.warn(
'@uppy/aws-s3: Could not read the ETag header. This likely means CORS is not configured correctly on the S3 Bucket. See https://uppy.io/docs/aws-s3/#setting-up-your-s3-bucket',
)
}
// Use ETag if available, otherwise fall back to location or a generated value.
// ETag is required for multipart completion, but for single uploads we can proceed without it.
const finalEtag = etag || location || `${Date.now()}`
onComplete?.(etag)
resolve({