From c0c126e210d21cfe2caac9a14e932c8482b3b018 Mon Sep 17 00:00:00 2001 From: Evgenia Karunus Date: Wed, 24 Jul 2024 06:09:44 +0500 Subject: [PATCH] Don't use `

` in Uppy markup (#5355) * everywhere - don't use `

` in Uppy markup * `/dev/Dashboard.js` - add defence against using heading tags --- packages/@uppy/audio/src/PermissionsScreen.tsx | 4 ++-- packages/@uppy/webcam/src/PermissionsScreen.tsx | 4 ++-- private/dev/index.html | 11 +++++++++-- 3 files changed, 13 insertions(+), 6 deletions(-) diff --git a/packages/@uppy/audio/src/PermissionsScreen.tsx b/packages/@uppy/audio/src/PermissionsScreen.tsx index 5cf185c6e..7dff6f9e8 100644 --- a/packages/@uppy/audio/src/PermissionsScreen.tsx +++ b/packages/@uppy/audio/src/PermissionsScreen.tsx @@ -12,9 +12,9 @@ export default (props: PermissionsScreenProps) => { return (
{icon()}
-

+
{hasAudio ? i18n('allowAudioAccessTitle') : i18n('noAudioTitle')} -

+

{hasAudio ? i18n('allowAudioAccessDescription') diff --git a/packages/@uppy/webcam/src/PermissionsScreen.tsx b/packages/@uppy/webcam/src/PermissionsScreen.tsx index 30a8e279e..242cb5f7b 100644 --- a/packages/@uppy/webcam/src/PermissionsScreen.tsx +++ b/packages/@uppy/webcam/src/PermissionsScreen.tsx @@ -15,9 +15,9 @@ export default function PermissionsScreen({ return (

{icon()}
-

+
{hasCamera ? i18n('allowAccessTitle') : i18n('noCameraTitle')} -

+

{hasCamera ? i18n('allowAccessDescription') diff --git a/private/dev/index.html b/private/dev/index.html index 05ba333ca..c22ebd63a 100644 --- a/private/dev/index.html +++ b/private/dev/index.html @@ -22,6 +22,7 @@ margin: auto; } + /* css to make sure that Dashboard's css overrides page css */ button, input { color: green; @@ -29,8 +30,6 @@ text-align: right; border: 2px solid purple; } - - /* css to make sure that Dashboard's css overrides page css */ ul { margin: 60px; } @@ -40,6 +39,14 @@ a { color: purple; } + h1, + h2, + h3, + h4, + h5, + h6 { + color: green; + }