From 9699e58b5ad618d6550e69cedd42ab261fb153fa Mon Sep 17 00:00:00 2001 From: Mikael Finstad Date: Tue, 21 Nov 2023 19:10:40 +0900 Subject: [PATCH] @uppy/companion-client: fix log type error (#4766) * fix logging bug * Update Provider.js --- packages/@uppy/companion-client/src/Provider.js | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/packages/@uppy/companion-client/src/Provider.js b/packages/@uppy/companion-client/src/Provider.js index 28a7a38f7..a3ebb5c7e 100644 --- a/packages/@uppy/companion-client/src/Provider.js +++ b/packages/@uppy/companion-client/src/Provider.js @@ -111,7 +111,17 @@ export default class Provider extends RequestClient { const authWindow = window.open(link, '_blank') const handleToken = (e) => { if (e.source !== authWindow) { - this.uppy.log.warn('ignoring event from unknown source', e) + let jsonData = '' + try { + // TODO improve our uppy logger so that it can take an arbitrary number of arguments, + // each either objects, errors or strings, + // then we don’t have to manually do these things like json stringify when logging. + // the logger should never throw an error. + jsonData = JSON.stringify(e.data) + } catch (err) { + // in case JSON.stringify fails (ignored) + } + this.uppy.log(`ignoring event from unknown source ${jsonData}`, 'warning') return }