transloadit: add type: TUS_ERROR|API_ERROR|STATUS_ERROR to reports

This commit is contained in:
Renée Kooi 2019-04-24 16:53:31 +02:00
parent 5f38ece7ec
commit 9644df7eee
No known key found for this signature in database
GPG key ID: 8CDD5F0BC448F040
2 changed files with 12 additions and 8 deletions

View file

@ -46,7 +46,7 @@ module.exports = class Client {
}
return assembly
}).catch((err) => this._reportError(err, { url }))
}).catch((err) => this._reportError(err, { url, type: 'API_ERROR' }))
}
/**
@ -60,7 +60,7 @@ module.exports = class Client {
const url = `${assembly.assembly_ssl_url}/reserve_file?size=${size}`
return fetch(url, { method: 'post' })
.then((response) => response.json())
.catch((err) => this._reportError(err, { assembly, file, url }))
.catch((err) => this._reportError(err, { assembly, file, url, type: 'API_ERROR' }))
}
/**
@ -82,7 +82,7 @@ module.exports = class Client {
const url = `${assembly.assembly_ssl_url}/add_file?${qs}`
return fetch(url, { method: 'post' })
.then((response) => response.json())
.catch((err) => this._reportError(err, { assembly, file, url }))
.catch((err) => this._reportError(err, { assembly, file, url, type: 'API_ERROR' }))
}
/**
@ -91,8 +91,10 @@ module.exports = class Client {
* @param {object} assembly
*/
cancelAssembly (assembly) {
return fetch(assembly.assembly_ssl_url, { method: 'delete' })
const url = assembly.assembly_ssl_url
return fetch(url, { method: 'delete' })
.then((response) => response.json())
.catch((err) => this._reportError(err, { url, type: 'API_ERROR' }))
}
/**
@ -103,7 +105,7 @@ module.exports = class Client {
getAssemblyStatus (url) {
return fetch(url)
.then((response) => response.json())
.catch((err) => this._reportError(err, { url }))
.catch((err) => this._reportError(err, { url, type: 'STATUS_ERROR' }))
}
submitError (err, { endpoint, instance, assembly }) {
@ -123,12 +125,14 @@ module.exports = class Client {
}).then((response) => response.json())
}
_reportError (err, params = {}) {
_reportError (err, params) {
if (this.opts.errorReporting === false) {
throw err
}
const opts = {}
const opts = {
type: params.type
}
if (params.assembly) {
opts.assembly = params.assembly.assembly_id
opts.instance = params.assembly.instance

View file

@ -676,7 +676,7 @@ module.exports = class Transloadit extends Plugin {
const url = err.originalRequest && err.originalRequest.responseURL
? err.originalRequest.responseURL
: null
this.client.submitError(err, { url }).then((_) => {
this.client.submitError(err, { url, type: 'TUS_ERROR' }).then((_) => {
// if we can't report the error that sucks
})
}