diff --git a/.eslintrc.js b/.eslintrc.js index 645bdbc35..84b9bee40 100644 --- a/.eslintrc.js +++ b/.eslintrc.js @@ -335,18 +335,6 @@ module.exports = { files: ['./packages/@uppy/companion/**/*.js'], rules: { 'no-underscore-dangle': 'off', - - // transloadit rules we would like to enforce in the future - // but will require separate PRs to gradually get there - // and so the meantime: just warn - 'class-methods-use-this': 'warn', - 'consistent-return': 'warn', - 'global-require': 'warn', - 'import/order': 'warn', - 'no-param-reassign': 'warn', - 'no-redeclare': 'warn', - 'no-shadow': 'warn', - 'no-use-before-define': 'warn', }, }, { diff --git a/packages/@uppy/companion/src/server/Uploader.js b/packages/@uppy/companion/src/server/Uploader.js index fff377318..568efb780 100644 --- a/packages/@uppy/companion/src/server/Uploader.js +++ b/packages/@uppy/companion/src/server/Uploader.js @@ -24,7 +24,7 @@ const { stat, unlink } = fs.promises // @ts-ignore - typescript resolves this this to a hoisted version of // serialize-error that ships with a declaration file, we are using a version // here that does not have a declaration file -const serializeError = require('serialize-error') +const serializeError = require('serialize-error') // eslint-disable-line import/order const emitter = require('./emitter') const { jsonStringify, hasMatch } = require('./helpers/utils') const logger = require('./logger') diff --git a/packages/@uppy/companion/src/server/controllers/deauth-callback.js b/packages/@uppy/companion/src/server/controllers/deauth-callback.js index de5f39483..84fec39a5 100644 --- a/packages/@uppy/companion/src/server/controllers/deauth-callback.js +++ b/packages/@uppy/companion/src/server/controllers/deauth-callback.js @@ -8,7 +8,6 @@ async function deauthCallback ({ body, companion, headers }, res, next) { try { const { data, status } = await companion.provider.deauthorizationCallback({ companion, body, headers }) res.status(status || 200).json(data) - return } catch (err) { if (respondWithError(err, res)) return next(err)