Mirrors/uppy
1
0
Fork 0
mirror of https://github.com/transloadit/uppy.git synced 2026-08-01 22:33:57 +00:00
Code Issues Projects Releases Wiki Activity

Fix endless webcam re-render with Golden Retriever (#4111)

Browse source 
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
This commit is contained in:
Merlijn Vos 2022-09-19 13:58:54 +02:00 • committed by GitHub
parent b23805ee29
commit 895e96fa8e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

8
packages/@uppy/golden-retriever/src/index.js
View file

@ -113,7 +113,9 @@ export default class GoldenRetriever extends BasePlugin {
// If all files have been removed by the user, clear recovery state
if (Object.keys(filesToSave).length === 0) {
this.uppy.setState({ recoveredState: null })
if (this.uppy.getState().recoveredState !== null) {
this.uppy.setState({ recoveredState: null })
}
MetaDataStore.cleanup(this.uppy.opts.id)
return
}
@ -350,7 +352,6 @@ export default class GoldenRetriever extends BasePlugin {
})
} else {
this.uppy.log('[GoldenRetriever] No files need to be loaded, only restoring processing state...')
this.onBlobsLoaded([])
}
}
@ -361,6 +362,9 @@ export default class GoldenRetriever extends BasePlugin {
this.uppy.on('file-added', this.addBlobToStores)
this.uppy.on('file-editor:complete', this.replaceBlobInStores)
this.uppy.on('file-removed', this.removeBlobFromStores)
// TODO: the `state-update` is bad practise. It fires on any state change in Uppy
// or any state change in any of the plugins. We should to able to only listen
// for the state changes we need, somehow.
this.uppy.on('state-update', this.saveFilesStateToLocalStorage)
this.uppy.on('restore-confirmed', this.handleRestoreConfirmed)
this.uppy.on('restore-canceled', this.abortRestore)