Mirrors/uppy
1
0
Fork 0
mirror of https://github.com/transloadit/uppy.git synced 2026-01-23 02:25:07 +00:00
Code Issues Projects Releases Wiki Activity

properly remove event listener for "focus" and "click" (#6116)

Browse source 
fix https://github.com/transloadit/uppy/issues/6115

---------

Co-authored-by: Mikael Finstad <finstaden@gmail.com>
This commit is contained in:
HKB 2026-01-05 21:49:14 +08:00 • committed by GitHub
parent 23186da45d
commit 6975782339
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 15 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

5
.changeset/nine-goats-attend.md Normal file
View file

@ -0,0 +1,5 @@
---
"@uppy/dashboard": patch
---
Remove event listener for `focus` and `click`, preventing a memory leak.

12
packages/@uppy/dashboard/src/Dashboard.tsx
View file

@ -1028,8 +1028,16 @@ export default class Dashboard<M extends Meta, B extends Body> extends UIPlugin<
this.uppy.off('files-added', this.#generateLargeThumbnailIfSingleFile) this.uppy.off('files-added', this.#generateLargeThumbnailIfSingleFile)
this.uppy.off('file-removed', this.#generateLargeThumbnailIfSingleFile) this.uppy.off('file-removed', this.#generateLargeThumbnailIfSingleFile)
document.removeEventListener('focus', this.recordIfFocusedOnUppyRecently) document.removeEventListener(
document.removeEventListener('click', this.recordIfFocusedOnUppyRecently) 'focus',
this.recordIfFocusedOnUppyRecently,
true,
)
document.removeEventListener(
'click',
this.recordIfFocusedOnUppyRecently,
true,
)
if (this.opts.inline) { if (this.opts.inline) {
this.el!.removeEventListener('keydown', this.handleKeyDownInInline) this.el!.removeEventListener('keydown', this.handleKeyDownInInline)